Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent room avatars above the room list very slowly scroll by mouse wheel #9394

Closed
progserega opened this issue Apr 5, 2019 · 12 comments · Fixed by matrix-org/matrix-react-sdk#3051
Assignees
Labels
A-Breadcrumbs P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@progserega
Copy link

1

Scroll by mouse is now work in last develop version of riot-web. But it is very slowly.

Version information

For the web app:

version riot-web: ab136c4-react-2ca281f6b7b7-js-0a82c8400696
version olm: 3.0.0

@turt2live
Copy link
Member

Is it possible to get a gif or video of what slowly means?

@progserega
Copy link
Author

@progserega
Copy link
Author

In room list scrolling by mouse is nice. It is slow only in new area "recent rooms".

@turt2live
Copy link
Member

oh wow, that is painful.

@jryans
Copy link
Collaborator

jryans commented Apr 8, 2019

#9400 might be a similar issue.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 8, 2019
See element-hq/element-web#9400
See element-hq/element-web#9394

Tolerances are defined as a device-only setting to give advanced users an option to override the values. No UI is exposed for this. 

The default values are picked for assumptions on comfort, however as people change the tolerances themselves the defaults may need to change.
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 8, 2019
See element-hq/element-web#9400
See element-hq/element-web#9394

Tolerances are defined as a device-only setting to give advanced users an option to override the values. No UI is exposed for this. 

The default values are picked for assumptions on comfort, however as people change the tolerances themselves the defaults may need to change.
@turt2live turt2live self-assigned this Apr 8, 2019
@turt2live
Copy link
Member

@progserega can you try this again on the latest develop?

@progserega
Copy link
Author

Try on https://riot.im/develop - now scroll faster x1.5, I think. But still slow.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 11, 2019
Fixes element-hq/element-web#9394
Fixes element-hq/element-web#9400

Numbers chosen based on user feedback. The setting has also been removed because it isn't really needed anymore.
@progserega
Copy link
Author

progserega commented May 7, 2019

At last develop breadcrumb not scrolling by mouse wheel.

url: https://riot.im/develop/
riot-web: 814b529-react-09a9b2e15ea6-js-ee8a4698a94a
olm: 3.1.0
firefox 66.0.3 (64bit)
Linux ubuntu 16.0.4

@turt2live turt2live reopened this May 8, 2019
@jryans
Copy link
Collaborator

jryans commented May 8, 2019

@turt2live Is there more work to do here? I'm unsure why this was reopened...

@turt2live
Copy link
Member

Bug report of it not working, so I've put it back on my list to investigate.

@progserega
Copy link
Author

Is there more work to do here? I'm unsure why this was reopened...

Bug not fixed (video create today):
https://yadi.sk/i/2KYmwH-YXBPhig

@turt2live turt2live added defect S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 24, 2019
@anoadragon453
Copy link
Member

Can confirm this is still a problem for me, but only in Firefox: https://streamable.com/nfezn

Chrome is fine: https://streamable.com/hx44d

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 3, 2019
Smooth scrolling browsers (Firefox) use the relative area to determine how much scroll to apply. Because breadcrumbs are short vertically, the scroll amount is minimal (3 units) in the Y direction. On browsers which don't smooth scroll the units are usually much higher (100 in Chrome on Win 10). Users seem to expect the scrolling to be quicker due to the horizontal space on breadcrumbs, so we add a bit more power to their scroll when it looks small.

Fixes element-hq/element-web#9394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Breadcrumbs P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants