Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.well-known not honored/read on initial loading of "sign in" page #9224

Closed
olmari opened this issue Mar 20, 2019 · 3 comments
Closed

.well-known not honored/read on initial loading of "sign in" page #9224

olmari opened this issue Mar 20, 2019 · 3 comments
Assignees
Labels
A-Login A-Registration P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@olmari
Copy link

olmari commented Mar 20, 2019

Description

When we configure our riot-web in our webserver to use "default_server_name": "hacklab.fi" and then go to our riot webpage and click "sign in", riot says "Sign in to your Matrix account on matrix.org", when it should say "..on hacklab.fi", refreshing page corrects it.

ADD/EDIT: To clarify: testing shows this is not only cosmetic, apparently .well-known isn't read at all, as trying to login with only username without server-part in name says that wrong username, but when refreshed page it works.

Steps to reproduce

  • Prerequisite: have working .well-known on hacklab.fi server for matrix http://hacklab.fi/.well-known/matrix/client
  • Configure "default_server_name": "hacklab.fi" on config.json
  • Go to https://riot.hacklab.fi and click "sign in"
  • Observe page wrongfully saying "Sign in to your Matrix account on matrix.org"
  • Refresh the page
  • Observe page rightfully saying "Sign in to your Matrix account on hacklab.fi"

Log: not sent

Version information

  • Platform: web (in-browser)

For the web app:

  • Browser: Chrome 73.0.3683.75 and Firefox 65.0.1 tested
  • OS: Windows 10, Ubuntu 18.10 tested
  • URL: https://riot.hacklab.fi version 1.0.4
@turt2live turt2live self-assigned this Mar 22, 2019
@turt2live turt2live added P1 X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Registration A-Login labels Mar 22, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 23, 2019
This is ultimately the fix for element-hq/element-web#9224 however it is not really great. By not logging out of the guest account, getCurrentHsUrl() returns the wrong homeserver URL (matrix.org) instead of the discovered one.
@turt2live
Copy link
Member

This is effectively blocked on #9290 so we can figure out what the actual relationship is supposed to be.

@turt2live
Copy link
Member

Transferring fire status to #9290 and tracking progress there, as that's where the fix lies.

@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#3001 - it won't make it into 1.2.0, but should be in the next regularly scheduled release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Login A-Registration P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

2 participants