Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS console is being spammed with Promise being deprecated #7409

Closed
turt2live opened this issue Sep 27, 2018 · 9 comments
Closed

JS console is being spammed with Promise being deprecated #7409

turt2live opened this issue Sep 27, 2018 · 9 comments
Labels
P1 T-Task Tasks for the team like planning X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@turt2live
Copy link
Member

Warning: Promise.defer is deprecated and will be removed in a future version. Use new Promise instead.

This started happening with the webpack 4 changes
@lampholder lampholder added T-Task Tasks for the team like planning P1 labels Oct 1, 2018
@lampholder
Copy link
Member

The last thing the console needs is more spam.

What's the right way to fix this? Silence the warnings? Or heed them?

@lampholder lampholder added the X-Needs-Info This issue is blocked awaiting information from the reporter label Oct 1, 2018
@turt2live
Copy link
Member Author

I'd vote for fixing them. They seem to be coming from deep within the js-sdk, so this may be non-trivial to fix. I'm not sure suppressing them is a good idea given it's already at the deprecation stage and we risk forgetting about it and having it all break down on us.

@aaronraimist
Copy link
Collaborator

aaronraimist commented Oct 1, 2018 •
edited
Loading

Doesn't look super difficult to fix

How to fix: https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Promise.jsm/Deferred

Example of a fix: https://github.com/matrix-org/matrix-react-sdk/pull/1292/files

@turt2live
Copy link
Member Author

Hopefully they are all that simple...

@aaronraimist aaronraimist mentioned this issue Oct 2, 2018
Merged
aaronraimist added a commit to aaronraimist/riot-web that referenced this issue Oct 3, 2018
@aaronraimist
Fix Promise.defer warnings in getconfig.js (element-hq#7409)
37b2c79 
Signed-off-by: Aaron Raimist <[email protected]>
aaronraimist added a commit to aaronraimist/riot-web that referenced this issue Oct 3, 2018
@aaronraimist
Fix Promise.defer warnings in index.js (element-hq#7409)
bae8a3a 
Signed-off-by: Aaron Raimist <[email protected]>
aaronraimist added a commit to aaronraimist/riot-web that referenced this issue Oct 3, 2018
@aaronraimist
Fix Promise.defer warnings in WebPlatform.js (element-hq#7409)
6fbbb98 
Signed-off-by: Aaron Raimist <[email protected]>
@aaronraimist aaronraimist mentioned this issue Oct 3, 2018
Merged
@richvdh richvdh mentioned this issue Oct 5, 2018
Closed
aaronraimist added a commit to aaronraimist/riot-web that referenced this issue Oct 5, 2018
@aaronraimist
Fix Promise.defer warnings in getconfig.js (element-hq#7409)
a5fb33d 
Signed-off-by: Aaron Raimist <[email protected]>
aaronraimist added a commit to aaronraimist/riot-web that referenced this issue Oct 5, 2018
@aaronraimist
Fix Promise.defer warnings in index.js (element-hq#7409)
54c46df 
Signed-off-by: Aaron Raimist <[email protected]>
aaronraimist added a commit to aaronraimist/riot-web that referenced this issue Oct 5, 2018
@aaronraimist
Fix Promise.defer warnings in WebPlatform.js (element-hq#7409)
401c85a 
Signed-off-by: Aaron Raimist <[email protected]>
aaronraimist added a commit to aaronraimist/riot-web that referenced this issue Oct 5, 2018
@aaronraimist
Fix lint warnings and turn warnings back on (element-hq#7409)
d035efb 
Signed-off-by: Aaron Raimist <[email protected]>
aaronraimist added a commit to aaronraimist/riot-web that referenced this issue Oct 5, 2018
@aaronraimist
Undo turning warnings back on (element-hq#7409)
d836ad8 
I guess that turns on warnings for everything, not just riot-web

Signed-off-by: Aaron Raimist <[email protected]>
turt2live added a commit that referenced this issue Oct 9, 2018
@turt2live
Merge pull request #7444 from aaronraimist/promise-defer
92db2b8 
 Fix riot-web Promise.defer warnings (#7409)
Ashaman- added a commit to neocrypto-io/riot-web that referenced this issue Oct 9, 2018
@Ashaman-
Develop rebase (#10)
2dda0d5 
* Document how to turn off Piwik and bug reports (element-hq#6738)

* Fix reskindex on matrix-react-side not being called if using build script

* Add text saying that bug reports aren't automatic

Signed-off-by: Aaron Raimist <[email protected]>

* Fix double-closed tags

* Use HTTPS cloning for riot-web too

* Silence bluebird warnings

* Disable webpack-dev-server auto reload

As per comment

* Fix Promise.defer warnings in getconfig.js (element-hq#7409)

Signed-off-by: Aaron Raimist <[email protected]>

* Fix Promise.defer warnings in index.js (element-hq#7409)

Signed-off-by: Aaron Raimist <[email protected]>

* Fix Promise.defer warnings in WebPlatform.js (element-hq#7409)

Signed-off-by: Aaron Raimist <[email protected]>

* Fix lint warnings and turn warnings back on (element-hq#7409)

Signed-off-by: Aaron Raimist <[email protected]>

* Undo turning warnings back on (element-hq#7409)

I guess that turns on warnings for everything, not just riot-web

Signed-off-by: Aaron Raimist <[email protected]>
@dbkr
Copy link
Member

dbkr commented Oct 10, 2018

Current status: I turned the warnings off in #7462 matrix-org/matrix-react-sdk#2198 and matrix-org/matrix-js-sdk#757 . @aaronraimist fixed the ones in riot-web and tuned warnings back on in #7444 but there are still plenty in react-sdk and js-sdk.

@aaronraimist
Copy link
Collaborator

aaronraimist commented Oct 10, 2018 •
edited
Loading

Actually I didn't turn them back on. I tried. It seems like when I did it turned the warnings back on in Riot-web, they also turned back on for matrix-react-sdk and matrox-js-sdk.

There are a few more I can do in matrix-react-sdk but I'm afraid there are a bunch that I'm not sure if I understand enough to be able to rewrite them.

@lampholder lampholder mentioned this issue Jan 21, 2019
Closed
@sparky-raccoon

This comment has been minimized.

Sign in to view
@turt2live

This comment has been minimized.

Sign in to view
@aaronraimist aaronraimist mentioned this issue Nov 8, 2019
Merged
@t3chguy
Copy link
Member

t3chguy commented Dec 17, 2019

Bluebird is now gone :D

@t3chguy t3chguy closed this as completed Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 T-Task Tasks for the team like planning X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dbkr @turt2live @lampholder @t3chguy @aaronraimist @sparky-raccoon