-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images expand in the timeline, causing a pop-in effect and scrolling issues #6654
Comments
I thought this was fixed (with the fix itself then causing #6652). But you filed this a day ago, which suggests it's still broken :\ |
In this case it's the opposite of #6652: images start small then expand. |
For scale on how annoying this is: I deployed 0.15.1 to our webserver and got 5 complaints in the first 15 minutes. Rolling back to 0.14.2 'fixes' the issue. |
OK. Now that we've released something, let's look at this more carefully. I'm pretty sure there's a simple solution that involves no fixup height shenanigans. |
Is this in an e2e room? |
I suspect it almost certainly is, which means its #6742 which I didn't realise was a regression |
This is not an e2e room. I generally don't use e2e personally except in rare cases. It's also not specific to a given room. As mentioned in riot-dev, I can try to get a recording if it helps. |
@turt2live can you confirm this fixed in 0.15.2 btw? |
Is fixed, thank you! |
thanks for bumping it earlier - i'd assumed it had been fixed earlier and for whatever reason we hadn't been seeing the problem. |
Description
This is a regression from a previous version (possibly related to the image stuff?). Whenever someone posts an image, it starts of at ~30px high then pops in to the full height after loading. This can sometimes throw off the scroll position, leaving the user at a weird place. Previously the space was reserved for the image in the timeline.
Version information
The text was updated successfully, but these errors were encountered: