Can't start DM from right panel

[kittykat]

Steps to reproduce

1. User1 send the MXID of user2 in a message
2. Click on MXID of user2 to open them in the right panel
3. Click on "Message" to start your first DM with user2

Outcome

What did you expect?

Go to the new DM and send my first message

What happened instead?

Infinispinner when hovering over "Message" in the right panel, DM doesn't start

Searching for the user in the user directory finds and starts a DM with them

Operating system

No response

Browser information

Chromium 110.0.5481.177 (Official Build) Arch Linux (64-bit)

URL for webapp

develop.element.io

Application version

Element version: 3903e86-react-de6a1a661cc9-js-41782c4593b4 Olm version: 3.2.12

Homeserver

matrix.org trying to start DM with half-shot.uk

Will you send logs?

No

[t3chguy]

@weeman1337 could this be a regression due to matrix-org/matrix-react-sdk#10256

[weeman1337]

Found in a live debug session with kat:

User has no avatar.

Uncaught (in promise) TypeError: user.getMxcAvatarUrl is not a function
    at openDMForUser (element-web-app.js:18359:22)
    at onClick (element-web-app.js:18545:13)
    at Object.Rb (vendors~init.js:71910:317)
    at Xb (vendors~init.js:71910:471)
    at Yb (vendors~init.js:71911:35)
    at Ze (vendors~init.js:71958:68)
    at se (vendors~init.js:71959:380)
    at vendors~init.js:71971:65
    at Jb (vendors~init.js:72150:189)
    at Nb (vendors~init.js:71908:57)

This information was not in the logs 😞

[t3chguy]

The issue is here, the member can be RoomMember | User

So the components downstream are making the wrong assumptions

openDMForUser (should actually be openDmForUser based on camelCase rules) should do something like: