Element white-screen-of-deaths when I hang up a Matrix-native 1:1 call

[lampholder]

Steps to reproduce

1. Start a call with Anthony (or Jordan)
2. Chat away for a bit
3. Go to a different room to enable PIP
4. Hang up
5. WSOD

Then you have to Task Manager kill the background processes to really terminate Element such that you can start it again cleanly.

Outcome

What did you expect?

No WSOD

What happened instead?

WSOD

Operating system

Windows 10

Application version

Element Nightly version: 0.0.1-nightly.2022111701 Olm version: 3.2.12

How did you install the app?

Website

Homeserver

lant.uk

Will you send logs?

Yes

[t3chguy]

Sounds like an OOM element-hq/element-desktop#680 - @lampholder can you check your system logs

[dbkr]

Seems to be reproducible if the other side hangs up. I didn't have to enter pip mode.

[robintown]

I can't reproduce this in Firefox, so I'm assuming this is specific to the desktop app

[dbkr]

Renderer process crash:

* thread vector-im/element-web#22, name = 'WebRTC_Network', stop reason = EXC_BAD_ACCESS (code=1, address=0x1f)
    frame #0: 0x0000000110aaaea8 Electron Framework`node::SetTracingController(v8::TracingController*) + 1118000
Electron Framework`node::SetTracingController:
->  0x110aaaea8 <+1118000>: ldrb   w8, [x1, #0x17]
    0x110aaaeac <+1118004>: tbnz   w9, #0x1f, 0x110aaaec8    ; <+1118032>
    0x110aaaeb0 <+1118008>: tbnz   w8, #0x7, 0x110aaaf10     ; <+1118104>
    0x110aaaeb4 <+1118012>: ldr    q0, [x1]
Target 0: (Electron Helper (Renderer)) stopped.
(lldb) bt
* thread vector-im/element-web#22, name = 'WebRTC_Network', stop reason = EXC_BAD_ACCESS (code=1, address=0x1f)
  * frame #0: 0x0000000110aaaea8 Electron Framework`node::SetTracingController(v8::TracingController*) + 1118000
    frame vector-im/element-web#1: 0x000000010b09af68 Electron Framework`v8::CpuProfileNode::GetParent() const + 54092
    frame vector-im/element-web#2: 0x000000010b09af68 Electron Framework`v8::CpuProfileNode::GetParent() const + 54092
    frame vector-im/element-web#3: 0x000000010b0997d4 Electron Framework`v8::CpuProfileNode::GetParent() const + 48056
    frame vector-im/element-web#4: 0x000000010b098638 Electron Framework`v8::CpuProfileNode::GetParent() const + 43548
    frame vector-im/element-web#5: 0x000000010b0982b4 Electron Framework`v8::CpuProfileNode::GetParent() const + 42648
    frame vector-im/element-web#6: 0x000000010b09dde8 Electron Framework`v8::CpuProfileNode::GetParent() const + 65996
    frame vector-im/element-web#7: 0x000000010c72cadc Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 2443644
    frame vector-im/element-web#8: 0x000000010af6e6f4 Electron Framework`v8::internal::DefaultEmbedderRootsHandler::ResetRoot(v8::TracedReference<v8::Value> const&) + 21744
    frame vector-im/element-web#9: 0x000000010d42d6f0 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16078224
    frame vector-im/element-web#10: 0x000000010d448394 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16187956
    frame vector-im/element-web#11: 0x000000010d3f64e4 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 15852420
    frame vector-im/element-web#12: 0x000000010d448d9c Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16190524
    frame vector-im/element-web#13: 0x000000010d4149c8 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 15976552
    frame vector-im/element-web#14: 0x000000010d462290 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16294192
    frame vector-im/element-web#15: 0x000000010d462404 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16294564
    frame vector-im/element-web#16: 0x000000010d47d9d0 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16406640
    frame vector-im/element-web#17: 0x000000019843c26c libsystem_pthread.dylib`_pthread_start + 148

[dbkr]

I'm still not really sure what's causing this crash - in a testing build, it crashes somewhere else before I can repro this crash. However, it seems fine with the previous build, v20.3.4, so I suggest downgrading to that for this release. If we want a fix for this release, our options are going to be limited to either downgrading one patch release or upgrading a major version (if indeed that fixes it - I haven't tested that).

https://github.com/electron/electron/releases/tag/v20.3.5 are the fixes we'd be missing out on: I don't believe any of them are critical. One is a crash when SSRCs are are not unique, but this crashes most times anyway.

[t3chguy]

Will accept backport into staging and upgrade to v21 to develop tomorrow