Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Start DM] Look for an actual account in case of email address #23353

Closed
giomfo opened this issue Sep 26, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#10150
Closed

[Start DM] Look for an actual account in case of email address #23353

giomfo opened this issue Sep 26, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#10150
Labels
A-DMs A-Identity-Server O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Regression

Comments

@giomfo
Copy link
Member

giomfo commented Sep 26, 2022

Your use case

When I open the contact picker to start a new DM, and type an email address, Element-Web doesn't check whether an actual account is discoverable for this email, whereas I configured an identity server in my profile.
image

Element-Android triggers a lookup request to replace this email address with a potential actual account

There is multiple advantages to discover user on email here:

  • the end user has the confirmation their contact has a matrix account
  • we worked on a new flow to create DM only on the first message Only create DM room when first message is sent #14736, select a matrix id is more powerful than an email in this case
  • prevent the application from creating a new DM whereas one is already created for this user

Have you considered any alternatives?

No response

Additional context

The same enhancement is requested for Element-iOS: element-hq/element-ios#6497
@giomfo giomfo mentioned this issue Sep 26, 2022
Closed
@t3chguy
Copy link
Member

t3chguy commented Sep 26, 2022

Hmm this seems to have regressed #2933

@weeman1337 weeman1337 added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-DMs A-Identity-Server O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 26, 2022
@weeman1337
Copy link
Contributor

Giving this a major severity, because you end up in having multiple DMs with the same person.

@giomfo giomfo mentioned this issue Sep 26, 2022
Closed
@giomfo giomfo changed the title [Start Chat] Look for an actual account in case of email address [Start DM] Look for an actual account in case of email address Sep 26, 2022
This was referenced Sep 26, 2022
Closed
Closed
@weeman1337 weeman1337 mentioned this issue Feb 13, 2023
Merged
3 tasks
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Mar 15, 2023
@su-ex
Merge tag 'v1.11.24' into sc
d615473 
* Remove experimental PWA support for Firefox and Safari ([\#24630](element-hq/element-web#24630)).
* Fix block code styling in rich text editor ([\#10246](matrix-org/matrix-react-sdk#10246)). Contributed by @alunturner.
* Poll history: fetch more poll history ([\#10235](matrix-org/matrix-react-sdk#10235)). Contributed by @kerryarchibald.
* Sort short/exact emoji matches before longer incomplete matches ([\#10212](matrix-org/matrix-react-sdk#10212)). Fixes element-hq/element-web#23210. Contributed by @grimhilt.
* Poll history: detail screen ([\#10172](matrix-org/matrix-react-sdk#10172)). Contributed by @kerryarchibald.
* Provide a more detailed error message than "No known servers" ([\#6048](matrix-org/matrix-react-sdk#6048)). Fixes element-hq/element-web#13247. Contributed by @aaronraimist.
* Say when a call was answered from a different device ([\#10224](matrix-org/matrix-react-sdk#10224)).
* Widget permissions customizations using module api ([\#10121](matrix-org/matrix-react-sdk#10121)). Contributed by @maheichyk.
* Fix copy button icon overlapping with copyable text ([\#10227](matrix-org/matrix-react-sdk#10227)). Contributed by @Adesh-Pandey.
* Support joining non-peekable rooms via the module API ([\#10154](matrix-org/matrix-react-sdk#10154)). Contributed by @maheichyk.
* The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\#10200](matrix-org/matrix-react-sdk#10200)).
* Do not prompt for a password when doing a „reset all“ after login ([\#10208](matrix-org/matrix-react-sdk#10208)).
* Display "The sender has blocked you from receiving this message" error message instead of "Unable to decrypt message" ([\#10202](matrix-org/matrix-react-sdk#10202)). Contributed by @florianduros.
* Polls: show warning about undecryptable relations ([\#10179](matrix-org/matrix-react-sdk#10179)). Contributed by @kerryarchibald.
* Poll history: fetch last 30 days of polls ([\#10157](matrix-org/matrix-react-sdk#10157)). Contributed by @kerryarchibald.
* Poll history - ended polls list items ([\#10119](matrix-org/matrix-react-sdk#10119)). Contributed by @kerryarchibald.
* Remove threads labs flag and the ability to disable threads ([\#9878](matrix-org/matrix-react-sdk#9878)). Fixes element-hq/element-web#24365.
* Show a success dialog after setting up the key backup ([\#10177](matrix-org/matrix-react-sdk#10177)). Fixes element-hq/element-web#24487.
* Release Sign in with QR out of labs ([\#10182](matrix-org/matrix-react-sdk#10182)). Contributed by @hughns.
* Release Sign in with QR out of labs ([\#10066](matrix-org/matrix-react-sdk#10066)). Contributed by @hughns.
* Hide indent button in rte ([\#10149](matrix-org/matrix-react-sdk#10149)). Contributed by @alunturner.
* Add option to find own location in map views ([\#10083](matrix-org/matrix-react-sdk#10083)).
* Render poll end events in timeline ([\#10027](matrix-org/matrix-react-sdk#10027)). Contributed by @kerryarchibald.
* Let electron-builder correctly set StartupWMClass ([\element-hq#526](element-hq#526)). Fixes element-hq/element-web#13780.
* Use the room avatar as a placeholder in calls ([\#10231](matrix-org/matrix-react-sdk#10231)).
* Fix calls showing as 'connecting' after hangup ([\#10223](matrix-org/matrix-react-sdk#10223)).
* Stop access token overflowing the box ([\#10069](matrix-org/matrix-react-sdk#10069)). Fixes element-hq/element-web#24023. Contributed by @sbjaj33.
* Prevent multiple Jitsi calls started at the same time ([\#10183](matrix-org/matrix-react-sdk#10183)). Fixes element-hq/element-web#23009.
* Make localization keys compatible with agglutinative and/or SOV type languages ([\#10159](matrix-org/matrix-react-sdk#10159)). Contributed by @luixxiul.
* Add link to next file in the export ([\#10190](matrix-org/matrix-react-sdk#10190)). Fixes element-hq/element-web#20272. Contributed by @grimhilt.
* Ended poll tiles: add ended the poll message ([\#10193](matrix-org/matrix-react-sdk#10193)). Fixes element-hq/element-web#24579. Contributed by @kerryarchibald.
* Fix accidentally inverted condition for room ordering ([\#10178](matrix-org/matrix-react-sdk#10178)). Fixes element-hq/element-web#24527. Contributed by @justjanne.
* Re-focus the composer on dialogue quit ([\#10007](matrix-org/matrix-react-sdk#10007)). Fixes element-hq/element-web#22832. Contributed by @Ashu999.
* Try to resolve emails before creating a DM ([\#10164](matrix-org/matrix-react-sdk#10164)).
* Disable poll response loading test ([\#10168](matrix-org/matrix-react-sdk#10168)). Contributed by @justjanne.
* Fix email lookup in invite dialog ([\#10150](matrix-org/matrix-react-sdk#10150)). Fixes element-hq/element-web#23353.
* Remove duplicate white space characters from translation keys ([\#10152](matrix-org/matrix-react-sdk#10152)). Contributed by @luixxiul.
* Fix the caption of new sessions manager on Labs settings page for localization ([\#10143](matrix-org/matrix-react-sdk#10143)). Contributed by @luixxiul.
* Prevent start another DM with a user if one already exists ([\#10127](matrix-org/matrix-react-sdk#10127)). Fixes element-hq/element-web#23138.
* Remove white space characters before the horizontal ellipsis ([\#10130](matrix-org/matrix-react-sdk#10130)). Contributed by @luixxiul.
* Fix Selectable Text on 'Delete All' and 'Retry All' Buttons ([\#10128](matrix-org/matrix-react-sdk#10128)). Fixes element-hq/element-web#23232. Contributed by @akshattchhabra.
* Correctly Identify emoticons ([\#10108](matrix-org/matrix-react-sdk#10108)). Fixes element-hq/element-web#19472. Contributed by @adarsh-sgh.
* Remove a redundant white space ([\#10129](matrix-org/matrix-react-sdk#10129)). Contributed by @luixxiul.
su-ex added a commit to SchildiChat/element-web that referenced this issue Mar 15, 2023
@su-ex
Merge tag 'v1.11.24' into sc
a120e8e 
* Remove experimental PWA support for Firefox and Safari ([\element-hq#24630](element-hq#24630)).
* Fix block code styling in rich text editor ([\element-hq#10246](matrix-org/matrix-react-sdk#10246)). Contributed by @alunturner.
* Poll history: fetch more poll history ([\element-hq#10235](matrix-org/matrix-react-sdk#10235)). Contributed by @kerryarchibald.
* Sort short/exact emoji matches before longer incomplete matches ([\element-hq#10212](matrix-org/matrix-react-sdk#10212)). Fixes element-hq#23210. Contributed by @grimhilt.
* Poll history: detail screen ([\element-hq#10172](matrix-org/matrix-react-sdk#10172)). Contributed by @kerryarchibald.
* Provide a more detailed error message than "No known servers" ([\element-hq#6048](matrix-org/matrix-react-sdk#6048)). Fixes element-hq#13247. Contributed by @aaronraimist.
* Say when a call was answered from a different device ([\element-hq#10224](matrix-org/matrix-react-sdk#10224)).
* Widget permissions customizations using module api ([\element-hq#10121](matrix-org/matrix-react-sdk#10121)). Contributed by @maheichyk.
* Fix copy button icon overlapping with copyable text ([\element-hq#10227](matrix-org/matrix-react-sdk#10227)). Contributed by @Adesh-Pandey.
* Support joining non-peekable rooms via the module API ([\element-hq#10154](matrix-org/matrix-react-sdk#10154)). Contributed by @maheichyk.
* The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\element-hq#10200](matrix-org/matrix-react-sdk#10200)).
* Do not prompt for a password when doing a „reset all“ after login ([\element-hq#10208](matrix-org/matrix-react-sdk#10208)).
* Display "The sender has blocked you from receiving this message" error message instead of "Unable to decrypt message" ([\element-hq#10202](matrix-org/matrix-react-sdk#10202)). Contributed by @florianduros.
* Polls: show warning about undecryptable relations ([\element-hq#10179](matrix-org/matrix-react-sdk#10179)). Contributed by @kerryarchibald.
* Poll history: fetch last 30 days of polls ([\element-hq#10157](matrix-org/matrix-react-sdk#10157)). Contributed by @kerryarchibald.
* Poll history - ended polls list items ([\element-hq#10119](matrix-org/matrix-react-sdk#10119)). Contributed by @kerryarchibald.
* Remove threads labs flag and the ability to disable threads ([\element-hq#9878](matrix-org/matrix-react-sdk#9878)). Fixes element-hq#24365.
* Show a success dialog after setting up the key backup ([\element-hq#10177](matrix-org/matrix-react-sdk#10177)). Fixes element-hq#24487.
* Release Sign in with QR out of labs ([\element-hq#10182](matrix-org/matrix-react-sdk#10182)). Contributed by @hughns.
* Hide indent button in rte ([\element-hq#10149](matrix-org/matrix-react-sdk#10149)). Contributed by @alunturner.
* Add option to find own location in map views ([\element-hq#10083](matrix-org/matrix-react-sdk#10083)).
* Render poll end events in timeline ([\element-hq#10027](matrix-org/matrix-react-sdk#10027)). Contributed by @kerryarchibald.
* Use the room avatar as a placeholder in calls ([\element-hq#10231](matrix-org/matrix-react-sdk#10231)).
* Fix calls showing as 'connecting' after hangup ([\element-hq#10223](matrix-org/matrix-react-sdk#10223)).
* Stop access token overflowing the box ([\element-hq#10069](matrix-org/matrix-react-sdk#10069)). Fixes element-hq#24023. Contributed by @sbjaj33.
* Prevent multiple Jitsi calls started at the same time ([\element-hq#10183](matrix-org/matrix-react-sdk#10183)). Fixes element-hq#23009.
* Make localization keys compatible with agglutinative and/or SOV type languages ([\element-hq#10159](matrix-org/matrix-react-sdk#10159)). Contributed by @luixxiul.
* Add link to next file in the export ([\element-hq#10190](matrix-org/matrix-react-sdk#10190)). Fixes element-hq#20272. Contributed by @grimhilt.
* Ended poll tiles: add ended the poll message ([\element-hq#10193](matrix-org/matrix-react-sdk#10193)). Fixes element-hq#24579. Contributed by @kerryarchibald.
* Fix accidentally inverted condition for room ordering ([\element-hq#10178](matrix-org/matrix-react-sdk#10178)). Fixes element-hq#24527. Contributed by @justjanne.
* Re-focus the composer on dialogue quit ([\element-hq#10007](matrix-org/matrix-react-sdk#10007)). Fixes element-hq#22832. Contributed by @Ashu999.
* Try to resolve emails before creating a DM ([\element-hq#10164](matrix-org/matrix-react-sdk#10164)).
* Disable poll response loading test ([\element-hq#10168](matrix-org/matrix-react-sdk#10168)). Contributed by @justjanne.
* Fix email lookup in invite dialog ([\element-hq#10150](matrix-org/matrix-react-sdk#10150)). Fixes element-hq#23353.
* Remove duplicate white space characters from translation keys ([\element-hq#10152](matrix-org/matrix-react-sdk#10152)). Contributed by @luixxiul.
* Fix the caption of new sessions manager on Labs settings page for localization ([\element-hq#10143](matrix-org/matrix-react-sdk#10143)). Contributed by @luixxiul.
* Prevent start another DM with a user if one already exists ([\element-hq#10127](matrix-org/matrix-react-sdk#10127)). Fixes element-hq#23138.
* Remove white space characters before the horizontal ellipsis ([\element-hq#10130](matrix-org/matrix-react-sdk#10130)). Contributed by @luixxiul.
* Fix Selectable Text on 'Delete All' and 'Retry All' Buttons ([\element-hq#10128](matrix-org/matrix-react-sdk#10128)). Fixes element-hq#23232. Contributed by @akshattchhabra.
* Correctly Identify emoticons ([\element-hq#10108](matrix-org/matrix-react-sdk#10108)). Fixes element-hq#19472. Contributed by @adarsh-sgh.
* Remove a redundant white space ([\element-hq#10129](matrix-org/matrix-react-sdk#10129)). Contributed by @luixxiul.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Mar 15, 2023
@su-ex
Merge tag 'v3.67.0' into sc
a350d86 
* Fix block code styling in rich text editor ([\matrix-org#10246](matrix-org#10246)). Contributed by @alunturner.
* Poll history: fetch more poll history ([\matrix-org#10235](matrix-org#10235)). Contributed by @kerryarchibald.
* Sort short/exact emoji matches before longer incomplete matches ([\matrix-org#10212](matrix-org#10212)). Fixes element-hq/element-web#23210. Contributed by @grimhilt.
* Poll history: detail screen ([\matrix-org#10172](matrix-org#10172)). Contributed by @kerryarchibald.
* Provide a more detailed error message than "No known servers" ([\matrix-org#6048](matrix-org#6048)). Fixes element-hq/element-web#13247. Contributed by @aaronraimist.
* Say when a call was answered from a different device ([\matrix-org#10224](matrix-org#10224)).
* Widget permissions customizations using module api ([\matrix-org#10121](matrix-org#10121)). Contributed by @maheichyk.
* Fix copy button icon overlapping with copyable text ([\matrix-org#10227](matrix-org#10227)). Contributed by @Adesh-Pandey.
* Support joining non-peekable rooms via the module API ([\matrix-org#10154](matrix-org#10154)). Contributed by @maheichyk.
* The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\matrix-org#10200](matrix-org#10200)).
* Do not prompt for a password when doing a „reset all“ after login ([\matrix-org#10208](matrix-org#10208)).
* Display "The sender has blocked you from receiving this message" error message instead of "Unable to decrypt message" ([\matrix-org#10202](matrix-org#10202)). Contributed by @florianduros.
* Polls: show warning about undecryptable relations ([\matrix-org#10179](matrix-org#10179)). Contributed by @kerryarchibald.
* Poll history: fetch last 30 days of polls ([\matrix-org#10157](matrix-org#10157)). Contributed by @kerryarchibald.
* Poll history - ended polls list items ([\matrix-org#10119](matrix-org#10119)). Contributed by @kerryarchibald.
* Remove threads labs flag and the ability to disable threads ([\matrix-org#9878](matrix-org#9878)). Fixes element-hq/element-web#24365.
* Show a success dialog after setting up the key backup ([\matrix-org#10177](matrix-org#10177)). Fixes element-hq/element-web#24487.
* Release Sign in with QR out of labs ([\matrix-org#10066](matrix-org#10066)). Contributed by @hughns.
* Hide indent button in rte ([\matrix-org#10149](matrix-org#10149)). Contributed by @alunturner.
* Add option to find own location in map views ([\matrix-org#10083](matrix-org#10083)).
* Render poll end events in timeline ([\matrix-org#10027](matrix-org#10027)). Contributed by @kerryarchibald.
* Use the room avatar as a placeholder in calls ([\matrix-org#10231](matrix-org#10231)).
* Fix calls showing as 'connecting' after hangup ([\matrix-org#10223](matrix-org#10223)).
* Stop access token overflowing the box ([\matrix-org#10069](matrix-org#10069)). Fixes element-hq/element-web#24023. Contributed by @sbjaj33.
* Prevent multiple Jitsi calls started at the same time ([\matrix-org#10183](matrix-org#10183)). Fixes element-hq/element-web#23009.
* Make localization keys compatible with agglutinative and/or SOV type languages ([\matrix-org#10159](matrix-org#10159)). Contributed by @luixxiul.
* Add link to next file in the export ([\matrix-org#10190](matrix-org#10190)). Fixes element-hq/element-web#20272. Contributed by @grimhilt.
* Ended poll tiles: add ended the poll message ([\matrix-org#10193](matrix-org#10193)). Fixes element-hq/element-web#24579. Contributed by @kerryarchibald.
* Fix accidentally inverted condition for room ordering ([\matrix-org#10178](matrix-org#10178)). Fixes element-hq/element-web#24527. Contributed by @justjanne.
* Re-focus the composer on dialogue quit ([\matrix-org#10007](matrix-org#10007)). Fixes element-hq/element-web#22832. Contributed by @Ashu999.
* Try to resolve emails before creating a DM ([\matrix-org#10164](matrix-org#10164)).
* Disable poll response loading test ([\matrix-org#10168](matrix-org#10168)). Contributed by @justjanne.
* Fix email lookup in invite dialog ([\matrix-org#10150](matrix-org#10150)). Fixes element-hq/element-web#23353.
* Remove duplicate white space characters from translation keys ([\matrix-org#10152](matrix-org#10152)). Contributed by @luixxiul.
* Fix the caption of new sessions manager on Labs settings page for localization ([\matrix-org#10143](matrix-org#10143)). Contributed by @luixxiul.
* Prevent start another DM with a user if one already exists ([\matrix-org#10127](matrix-org#10127)). Fixes element-hq/element-web#23138.
* Remove white space characters before the horizontal ellipsis ([\matrix-org#10130](matrix-org#10130)). Contributed by @luixxiul.
* Fix Selectable Text on 'Delete All' and 'Retry All' Buttons ([\matrix-org#10128](matrix-org#10128)). Fixes element-hq/element-web#23232. Contributed by @akshattchhabra.
* Correctly Identify emoticons ([\matrix-org#10108](matrix-org#10108)). Fixes element-hq/element-web#19472. Contributed by @adarsh-sgh.
* Remove a redundant white space ([\matrix-org#10129](matrix-org#10129)). Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-DMs A-Identity-Server O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix email lookup in invite dialog matrix-org/matrix-react-sdk
3 participants
@t3chguy @weeman1337 @giomfo