Labs beta card overflow on a small window #21554
Assignees
Labels
A-User-Settings
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Tolerable
Low/no impact on users
T-Defect
Comments
|
Before pushing a commit, I would like to know if it is fine to proceed with that design. If it should stay as it is, I'll close this issue. Thanks! |
|
It looks sane to me! |
germain-gg
added
S-Tolerable
|
What concerns me here is that the heights of cards area might be too large when there are more than a couple of tests, like three tests. To decrease the height of each card a little bit, for example I could try to align feedback and leave beta buttons horizontally when the animation image is wrapped, taking the length of their strings which depend on translation into consideration. |
|
This should look better. The feedback button is placed above and right of the other button.
|
kegsay
added a commit
to matrix-org/matrix-react-sdk
that referenced
this issue
Apr 14, 2022
* Release threads as a beta feature ([\#8081](#8081)). Fixes element-hq/element-web#21351. * More video rooms design updates ([\#8222](#8222)). * Update video rooms to new design specs ([\#8207](#8207)). Fixes element-hq/element-web#21515, element-hq/element-web#21516 element-hq/element-web#21519 and element-hq/element-web#21526. * Live Location Sharing - left panel warning with error ([\#8201](#8201)). * Live location sharing - Stop publishing location to beacons with consecutive errors ([\#8194](#8194)). * Live location sharing: allow retry when stop sharing fails ([\#8193](#8193)). * Allow voice messages to be scrubbed in the timeline ([\#8079](#8079)). Fixes element-hq/element-web#18713. * Live location sharing - stop sharing to beacons in rooms you left ([\#8187](#8187)). * Allow sending and thumbnailing AVIF images ([\#8172](#8172)). * Live location sharing - handle geolocation errors ([\#8179](#8179)). * Show voice room participants when not connected ([\#8136](#8136)). Fixes element-hq/element-web#21513. * Add margins between labs sections ([\#8169](#8169)). * Live location sharing - send geolocation beacon events - happy path ([\#8127](#8127)). * Add support for Animated (A)PNG ([\#8158](#8158)). Fixes element-hq/element-web#12967. * Don't form continuations from thread roots ([\#8166](#8166)). Fixes element-hq/element-web#20908. * Improve handling of animated GIF and WEBP images ([\#8153](#8153)). Fixes element-hq/element-web#16193 and element-hq/element-web#6684. * Wire up file preview for video files ([\#8140](#8140)). Fixes element-hq/element-web#21539. * When showing thread, always auto-focus its composer ([\#8115](#8115)). Fixes element-hq/element-web#21438. * Live location sharing - refresh beacon expiry in room ([\#8116](#8116)). * Use styled mxids in member list v2 ([\#8110](#8110)). Fixes element-hq/element-web#14825. Contributed by @SimonBrandner. * Delete groups (legacy communities system) ([\#8027](#8027)). Fixes element-hq/element-web#17532. * Add a prototype of voice rooms in labs ([\#8084](#8084)). Fixes element-hq/element-web#3546. * Fix editing `<ol>` tags with a non-1 start attribute ([\#8211](#8211)). Fixes element-hq/element-web#21625. * Fix URL previews being enabled when room first created ([\#8227](#8227)). Fixes element-hq/element-web#21659. * Don't use m.call for Jitsi video rooms ([\#8223](#8223)). * Scale emoji with size of surrounding text ([\#8224](#8224)). * Make "Jump to date" translatable ([\#8218](#8218)). * Normalize call buttons ([\#8129](#8129)). Fixes element-hq/element-web#21493. Contributed by @luixxiul. * Show room preview bar with maximised widgets ([\#8180](#8180)). Fixes element-hq/element-web#21542. * Update more strings to not wrongly mention room when it is/could be a space ([\#7722](#7722)). Fixes element-hq/element-web#20243 and element-hq/element-web#20910. * Fix issue with redacting via edit composer flow causing stuck editStates ([\#8184](#8184)). * Fix some image/video scroll jumps ([\#8182](#8182)). * Fix "react error on share dialog" ([\#8170](#8170)). Contributed by @yaya-usman. * Fix disambiguated profile in threads in bubble layout ([\#8168](#8168)). Fixes element-hq/element-web#21570. Contributed by @SimonBrandner. * Responsive BetaCard on Labs ([\#8154](#8154)). Fixes element-hq/element-web#21554. Contributed by @luixxiul. * Display button as inline in room directory dialog ([\#8164](#8164)). Fixes element-hq/element-web#21567. Contributed by @luixxiul. * Null guard TimelinePanel unmount edge ([\#8171](#8171)). * Fix beta pill label breaking ([\#8162](#8162)). Fixes element-hq/element-web#21566. Contributed by @luixxiul. * Strip relations when forwarding ([\#7929](#7929)). Fixes element-hq/element-web#19769, element-hq/element-web#18067 element-hq/element-web#21015 and element-hq/element-web#10924. * Don't try (and fail) to show replies for redacted events ([\#8141](#8141)). Fixes element-hq/element-web#21435. * Fix 3pid member info for space member list ([\#8128](#8128)). Fixes element-hq/element-web#21534. * Set max-width to user context menu ([\#8089](#8089)). Fixes element-hq/element-web#21486. Contributed by @luixxiul. * Fix issue with falsey hrefs being sent in events ([\#8113](#8113)). Fixes element-hq/element-web#21417. * Make video sizing consistent with images ([\#8102](#8102)). Fixes element-hq/element-web#20072.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
LabsOutcome
What did you expect?
The beta card should be wrapped like below.
after.mp4
What happened instead?
The GIF image on the right side is only partly displayed.
Operating system
No response
Browser information
No response
URL for webapp
localhost
Application version
develop branch
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: