Improve performance of RoomContext in RoomHeader #2857
Annotations
2 errors, 5 warnings, and 1 notice
Run Playwright tests:
playwright/e2e/spaces/threads-activity-centre/index.ts#L379
1) spaces/threads-activity-centre/threadsActivityCentre.spec.ts:141:9 › Threads Activity Centre › should mark all threads as read
Error: locator.click: Error: strict mode violation: getByLabel('Mark all as read') resolved to 2 elements:
1) <div tabindex="0" role="button" aria-label="Mark all as read" class="mx_AccessibleButton mx_TopUnreadMessagesBar_markAsRead"></div> aka getByRole('main').getByLabel('Mark all as read')
2) <button tabindex="0" role="button" aria-labelledby=":r74:" class="_icon-button_bh2qc_17">…</button> aka locator('#thread-panel').getByLabel('Mark all as read')
Call log:
- waiting for getByLabel('Mark all as read')
at spaces/threads-activity-centre/index.ts:379
377 | */
378 | clickMarkAllThreadsRead() {
> 379 | return this.page.getByLabel("Mark all as read").click();
| ^
380 | }
381 | }
382 |
at Helpers.clickMarkAllThreadsRead (/home/runner/work/element-web/element-web/playwright/e2e/spaces/threads-activity-centre/index.ts:379:57)
at /home/runner/work/element-web/element-web/playwright/e2e/spaces/threads-activity-centre/threadsActivityCentre.spec.ts:149:14
|
Run Playwright tests:
playwright/e2e/spaces/threads-activity-centre/index.ts#L283
1) spaces/threads-activity-centre/threadsActivityCentre.spec.ts:141:9 › Threads Activity Centre › should mark all threads as read
Error: expect(locator).toHaveScreenshot(expected)
39 pixels (ratio 0.04 of all image pixels) are different.
Expected: /home/runner/work/element-web/element-web/playwright/snapshots/spaces/threads-activity-centre/threadsActivityCentre.spec.ts/tac-no-indicator-linux.png
Received: /home/runner/work/element-web/element-web/playwright/test-results/spaces-threads-activity-ce-ffe63-ld-mark-all-threads-as-read/tac-no-indicator-actual.png
Diff: /home/runner/work/element-web/element-web/playwright/test-results/spaces-threads-activity-ce-ffe63-ld-mark-all-threads-as-read/tac-no-indicator-diff.png
Call log:
- expect.toHaveScreenshot(tac-no-indicator.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByRole('navigation', { name: 'Spaces' }).getByLabel('Threads')
- locator resolved to <button tabindex="0" type="button" role="button" id="radix-:r8:" data-state="closed" aria-label="Threads" aria-haspopup="menu" aria-expanded="false" aria-disabled="false" aria-labelledby=":ra:" data-indicator="success" class="_icon-button_bh2qc_17 mx_ThreadsActivityCentreButton">…</button>
- taking element screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 39 pixels (ratio 0.04 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByRole('navigation', { name: 'Spaces' }).getByLabel('Threads')
- locator resolved to <button tabindex="0" type="button" role="button" id="radix-:r8:" data-state="closed" aria-label="Threads" aria-haspopup="menu" aria-expanded="false" aria-disabled="false" aria-labelledby=":ra:" data-indicator="success" class="_icon-button_bh2qc_17 mx_ThreadsActivityCentreButton">…</button>
- taking element screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 39 pixels (ratio 0.04 of all image pixels) are different.
at spaces/threads-activity-centre/index.ts:283
281 | await expect(this.getTacButton().locator("[data-indicator='success']")).not.toBeVisible();
282 | await expect(this.getTacButton().locator("[data-indicator='critical']")).not.toBeVisible();
> 283 | await expect(this.getTacButton()).toMatchScreenshot("tac-no-indicator.png");
| ^
284 | }
285 |
286 | /**
at Helpers.assertNoTacIndicator (/home/runner/work/element-web/element-web/playwright/e2e/spaces/threads-activity-centre/index.ts:283:43)
at /home/runner/work/element-web/element-web/playwright/e2e/spaces/threads-activity-centre/threadsActivityCentre.spec.ts:151:9
|
Run Playwright tests:
timeline/timeline.spec.ts#L1
timeline/timeline.spec.ts took 2.9m
|
Run Playwright tests:
spotlight/spotlight.spec.ts#L1
spotlight/spotlight.spec.ts took 2.3m
|
Run Playwright tests:
threads/threads.spec.ts#L1
threads/threads.spec.ts took 36.5s
|
Run Playwright tests:
user-onboarding/user-onboarding-new.spec.ts#L1
user-onboarding/user-onboarding-new.spec.ts took 35.7s
|
Run Playwright tests:
widgets/widget-pip-close.spec.ts#L1
widgets/widget-pip-close.spec.ts took 23.1s
|
Run Playwright tests
1 flaky
spaces/threads-activity-centre/threadsActivityCentre.spec.ts:141:9 › Threads Activity Centre › should mark all threads as read
3 skipped
68 passed (10.4m)
|
Loading