Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow project to compile with Xcode 16.1 #7869

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

NicolasBuquet
Copy link

Project fails to compile with Xcode 16.1 due to Pod Sentry.

Update it from 7.15.0 to 8.40.1 seems to fix the problem.

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nicolas Buquet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Nicolas Buquet added 4 commits November 13, 2024 16:34
…uet/element-ios-tchap into nbuquet/xcode-16-1-pod-sentry
…uet/element-ios-tchap into nbuquet/xcode-16-1-pod-sentry
…uet/element-ios-tchap into nbuquet/xcode-16-1-pod-sentry
@NicolasBuquet
Copy link
Author

@giomfo @pixlwave
FYI.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.16%. Comparing base (eaedc34) to head (dfff740).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7869      +/-   ##
===========================================
+ Coverage    62.06%   62.16%   +0.09%     
===========================================
  Files          504      504              
  Lines        21096    21096              
  Branches      7964     7965       +1     
===========================================
+ Hits         13094    13115      +21     
+ Misses        7973     7960      -13     
+ Partials        29       21       -8     
Flag Coverage Δ
uitests 62.16% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants