Add option to find own location in map views

[Johennes]

This exposes the default "find my location" button in the map view dialog for static and live locations. When the user is currently live-sharing their own location, the button is hidden.

Todo

I couldn't find a suitable existing icon for this so I reused one of the map marker icons for demonstration purposes. We'll probably need to make a new one.

It also currently only centers the map on the user location when clicking for the first time.

Screenshots

Pull Request Checklist

• I read the contributing guide
• UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
• Accessibility has been taken into account.

• Pull request is based on the develop branch

• Pull request contains a changelog file in ./changelog.d
• You've made a self review of your PR
• Pull request includes screenshots or videos of UI changes
• Pull request includes a sign off

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Base: 12.09% // Head: 12.08% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (59ae3a8) compared to base (3972da8).
Patch coverage: 7.31% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7337      +/-   ##
===========================================
- Coverage    12.09%   12.08%   -0.01%     
===========================================
  Files         1637     1637              
  Lines       161830   161846      +16     
  Branches     66429    66484      +55     
===========================================
- Hits         19566    19564       -2     
- Misses      141618   141636      +18     
  Partials       646      646              

Flag	Coverage Δ
uitests	55.32% <9.09%> (-0.06%)	⬇️
unittests	5.97% <2.43%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
Config/CryptoSDKConfiguration.swift	0.00% <0.00%> (ø)
...ot/Categories/MatrixSDKCrypto+LocalizedError.swift	0.00% <ø> (ø)
Riot/Managers/Settings/RiotSettings.swift	88.42% <ø> (ø)
Riot/Modules/Analytics/Analytics.swift	9.41% <0.00%> (ø)
Riot/Modules/Application/LegacyAppDelegate.m	14.55% <ø> (ø)
...Modules/Home/AllChats/AllChatsViewController.swift	29.35% <0.00%> (ø)
Riot/Modules/Settings/SettingsViewController.m	0.00% <0.00%> (ø)
...haringViewer/LiveLocationSharingViewerModels.swift	9.09% <ø> (ø)
...SharingViewer/View/LiveLocationSharingViewer.swift	0.70% <0.00%> (-0.06%)	⬇️
...ocationSharingViewer/View/StaticLocationView.swift	0.00% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[gaelledel]

I'm not sure I understand the need of adding a button here as zoom in and finding user location should be automatic when opening the map. Also this is the space dedicated to the Sharing option why are you replacing it?

[Johennes]

Thanks for getting back @gaelledel.

I'm not sure I understand the need of adding a button here as zoom in and finding user location should be automatic when opening the map.

This is for the case when the user is not sharing their own location but instead viewing somebody else's location share.

Also this is the space dedicated to the Sharing option why are you replacing it?

The screenshot is from the live location map view. That one currently doesn't have the share button. You are right though that for static location shares, the map view would have to show both, the share button and the "find my location" button.

[gaelledel]

@Johennes You can find a design reference for this here https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=3103%3A64256&t=tF5nsVNzfBrN9ZYh-4