Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use npm in canary workflow #1572

Merged
merged 1 commit into from
Sep 28, 2023
Merged

ci: use npm in canary workflow #1572

merged 1 commit into from
Sep 28, 2023

Conversation

dsanders11
Copy link
Member

Summarize your changes:

Partially reverts #1570, the canary build needs to use npm when running commands in the checkout of electron/electron-quick-start.

@dsanders11 dsanders11 requested a review from a team as a code owner September 28, 2023 05:18
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1572 (dd294f5) into main (2962aac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1572   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          15       15           
  Lines         793      793           
=======================================
  Hits          758      758           
  Misses         35       35           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dsanders11 dsanders11 merged commit e99c4dc into main Sep 28, 2023
5 checks passed
@dsanders11 dsanders11 deleted the ci-partial-revert-use-yarn branch September 28, 2023 23:33
Copy link

🎉 This PR is included in version 18.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants