Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): include @types/appdmg in prod dependencies #213

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(types): include @types/appdmg in prod dependencies #213

merged 1 commit into from
Jul 2, 2024

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jul 2, 2024 •
edited
Loading

Now that we're exporting types from this package, we need to also export @types/appdmg since that type is used in the additionalDMGOptions property of ElectronInstallerDMGOptions.

@erickzhao erickzhao requested a review from felixrieseberg July 2, 2024 18:17
@erickzhao erickzhao merged commit c900733 into main Jul 2, 2024
4 checks passed
@erickzhao erickzhao deleted the types/prod-dependencies branch July 2, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikian erikian erikian approved these changes

@malept malept malept approved these changes

@felixrieseberg felixrieseberg Awaiting requested review from felixrieseberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erickzhao @malept @erikian