-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow api key and keychain notarize #7861
Conversation
🦋 Changeset detectedLatest commit: dccd0c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can you please add explicit types to the consts? |
fixed some types. however i'm really struggling to fix the types for
not sure if i'm misunderstanding something |
introduced in electron-userland#7861
see discussion in electron-userland#7859 and electron-userland#7861
This is a great improvement, however at the moment, it isn't functional. I opened a small fix to make it work: #7951 tldr The notarization tool never runs when the API key is set and notarize is set to |
see also #7859
I've tested this here https://github.com/mifi/lossless-cut/actions/runs/6719326573/job/18260738394
with a patched macPackager.js