Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use updatecli version in updatecli/install #176

Merged
merged 15 commits into from
Nov 29, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 29, 2024

Initial support for updatecli/updatecli-action#828

What

Set the version so that consumers can use their version or version-file.
The default version is the current version we use.

updatecli auto bump -> #178

@v1v v1v added the changelog:enhancement When you enhance an existing feature label Nov 29, 2024
@v1v v1v changed the title feat: use updatecli version feat: use updatecli version in updatecli/install Nov 29, 2024
@v1v v1v added the changelog:dependencies When you add or update a dependency label Nov 29, 2024
@v1v v1v marked this pull request as ready for review November 29, 2024 14:58
@v1v v1v removed the changelog:dependencies When you add or update a dependency label Nov 29, 2024
@v1v v1v requested a review from a team November 29, 2024 14:58
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Setup version file
run: |
echo "v0.87.0" > .tools-version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct?

should it be something like:

updatecli v0.87.0

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I've just added support for both cases:

@v1v v1v added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 703dd9f Nov 29, 2024
13 checks passed
@v1v v1v deleted the feature/updatecli-version branch November 29, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:enhancement When you enhance an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants