Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Fix azure.activitylogs.identity with a a concrete value #3019

Merged
merged 2 commits into from
Apr 7, 2022
Merged

[Azure] Fix azure.activitylogs.identity with a a concrete value #3019

merged 2 commits into from
Apr 7, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 6, 2022

What does this PR do?

This PR fixed azure.activitylogs.identity field with a concrete value and tested it with a new format sample activity log.
Error log without this fix:

(status=400): {"type":"mapper_parsing_exception","reason":"object mapping for [azure.activitylogs.identity] tried to parse field [identity] as object, but found a concrete value"}, dropping event!

Also with the new format, this PR added azure.activitylogs.identity_name, azure.activitylogs.tenant_id, azure.activitylogs.level and azure.activitylogs.operation_version fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner April 6, 2022 16:21
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 6, 2022
@elasticmachine
Copy link

elasticmachine commented Apr 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-06T16:24:38.030+0000

  • Duration: 11 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 86
Skipped 0
Total 86

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@@ -73,6 +73,11 @@ processors:
field: azure.activitylogs.location
target_field: geo.name
ignore_missing: true
- rename:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I got it right we where receiving both azure.activitylogs.identity.authorization = {...} and azure.activitylogs.identity = "abc", is this correct?

we now rename azure.activitylogs.identity = "abc" to azure.activitylogs.identity_name = "abc", do we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's right. azure.activitylogs.identity as a keyword is new added by azure seems like instead of an object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants