ti_custom: Add docs about retrieving ISAC feeds #12098
Open
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemamartinez
added
documentation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
| - Authentication Credentials: Username, password, API Key, or client certificate, as required by the ISAC. | ||
|
|
||
| 3. Set up the integration: | ||
| - The server URL and collection name should be used to build the URL as follows: `https://{server_url}/{api-root}/collections/{name}/objects/` |
There was a problem hiding this comment.
Suggested change
| - The server URL and collection name should be used to build the URL as follows: `https://{server_url}/{api-root}/collections/{name}/objects/` | |
| - The server URL and collection name should be used to build the URL as follows: `https://{base_url}/{api-root}/collections/{name}/objects/` |
Matches what's in the url variable description in the manifest, and avoids confusion with the above "Server URL" example https://example-isac.org/taxii/, which I assume would be {base_url} of example-isac.org and {api-root} of taxii.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Checklist
changelog.ymlfile.Related issues
Screenshots