Simplify gradle test task error reporting #59760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
breskeby
commented
Jul 17, 2020
•
breskeby
commented
- Avoid using extra plugin
- Avoid extra task listener (should be avoided related to Elasticsearch build and Gradle plugins should support Gradle configuration cache #57918 )
- Keep all logic for reporting failures in the TestListener
- Avoids overhead for non decorated tasks and up-to-date test tasks
- avoid using extra plugin - avoid extra task listener (should be avoided related to elastic#57918 ) - keep all logic in the listener
breskeby
added
:Delivery/Build
breskeby
changed the title
- makes linking output to the test task possible in GE console output
breskeby
commented
Jul 17, 2020
| throw new IllegalStateException(this.getClass().getName() + " can only be applied to the root project."); | ||
| } | ||
|
|
||
| project.getGradle().addListener(new TaskActionListener() { |
There was a problem hiding this comment.
Removing the task listener also fixes an incompatibility with upcoming gradle configuration cache. see https://docs.gradle.org/6.6-rc-1/userguide/configuration_cache.html#config_cache:requirements:build_listeners for details
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 21, 2020
* Simplify test error reporting - avoid using extra plugin - avoid extra task listener (should be avoided related to elastic#57918 ) - keep all logic in the listener
This was referenced Jul 21, 2020
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 21, 2020
* Simplify test error reporting - avoid using extra plugin - avoid extra task listener (should be avoided related to elastic#57918 ) - keep all logic in the listener
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 21, 2020
* Simplify test error reporting - avoid using extra plugin - avoid extra task listener (should be avoided related to elastic#57918 ) - keep all logic in the listener
breskeby
added a commit
that referenced
this pull request
Jul 21, 2020
breskeby
added a commit
that referenced
this pull request
Jul 21, 2020
breskeby
added a commit
that referenced
this pull request
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.