Enable elasticsearch-transport v7 to use Faraday >=2 #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to close elastic#2228. All credit for this goes to @picandocodigo, as these are the same changes made in elastic/elastic-transport-ruby#30 but for version 7.17 of `elastic-transport` – I just copy-pasted that code over.
|
💚 CLA has been signed |
|
I've signed the CLA 👍 |
picandocodigo
requested changes
Oct 25, 2023
Co-authored-by: Fernando Briano <[email protected]>
|
@picandocodigo If everything looks good, I would greatly appreciate it if a new version of the gem could be released with these changes, as I really need it for the projects that I'm working at! Please let me know if there's anything else you would like me to address. Thank you so much for your time! 🧉 |
picandocodigo
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to close #2228.
All credit for this goes to @picandocodigo, as these are the same changes made in elastic/elastic-transport-ruby#30 but for version 7.17 of
elastic-transport– I just copy-pasted those changes over.