Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes instantiating Client in Manticore implementation. #69

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

picandocodigo
Copy link
Member

Fixes #66

Copy link

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and confirmed it is able to send the header. Thank you for fixing it!

@picandocodigo picandocodigo merged commit 09ed00b into main Sep 21, 2023
20 checks passed
@picandocodigo picandocodigo deleted the order_66 branch September 21, 2023 13:42
picandocodigo added a commit to elastic/elasticsearch-ruby that referenced this pull request Sep 26, 2023
picandocodigo added a commit to elastic/elasticsearch-ruby that referenced this pull request Sep 26, 2023
picandocodigo added a commit to elastic/elasticsearch-ruby that referenced this pull request Sep 26, 2023
picandocodigo added a commit to elastic/elasticsearch-ruby that referenced this pull request Sep 26, 2023
picandocodigo added a commit to elastic/elasticsearch-ruby that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jruby/manticore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manticore transport unable to send custom headers with perform_request
2 participants