Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mac m1 support for auditbeat system/package #34433

Merged
merged 6 commits into from
Feb 1, 2023

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Jan 31, 2023

Type of change

  • Enhancement

What does this PR do?

Adds support for detecting homebrew packages on macs with apple silicon chips.

Why is it important?

Previously packages were not being detected on macs with m1 chips.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@ShourieG ShourieG requested a review from a team as a code owner January 31, 2023 11:22
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2023
@ShourieG ShourieG self-assigned this Jan 31, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-01T09:00:57.022+0000

  • Duration: 43 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 276
Skipped 49
Total 325

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ShourieG
Copy link
Contributor Author

ShourieG commented Feb 1, 2023

@efd6 updated the PR

@ShourieG ShourieG merged commit 25d920c into elastic:main Feb 1, 2023
@ShourieG ShourieG deleted the auditbeat/m1_fix branch February 1, 2023 10:00
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* added mac m1 support for auditbeat system/package

* updated changelog

* updated as per PR suggestions

* updated package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Audit Beat] Improve homebrew/packages detection for Apple Silicon chips
4 participants