Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed log naming syntax to not clash with ecs field names #34403

Merged
merged 2 commits into from
Jan 27, 2023
Merged

fixed log naming syntax to not clash with ecs field names #34403

merged 2 commits into from
Jan 27, 2023

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

updates log field names so that it does not clash with ecs field names.

Why is it important?

It important that ecs field names are not used as general log field names.

@ShourieG ShourieG requested a review from a team as a code owner January 27, 2023 07:01
@ShourieG ShourieG requested review from belimawr and faec and removed request for a team January 27, 2023 07:01
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 27, 2023
@ShourieG ShourieG requested a review from P1llus January 27, 2023 07:01
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 27, 2023
@ShourieG ShourieG added the backport-v8.6.0 Automated backport with mergify label Jan 27, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 27, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-27T07:08:58.419+0000

  • Duration: 73 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 2533
Skipped 172
Total 2705

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ShourieG ShourieG merged commit da62235 into elastic:main Jan 27, 2023
@mergify mergify bot mentioned this pull request Jan 27, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jan 27, 2023
@ShourieG @mergify
fixed log naming syntax to not clash with ecs field names (#34403)
f26a96f 
* fixed log naming syntax to not clash with ecs field names

* updated changelog

(cherry picked from commit da62235)
@ShourieG ShourieG deleted the abs/fix_log_name branch January 27, 2023 10:42
ShourieG added a commit that referenced this pull request Jan 27, 2023
@mergify @ShourieG
fixed log naming syntax to not clash with ecs field names (#34403) (#…
73396eb 
…34404)

* fixed log naming syntax to not clash with ecs field names

* updated changelog

(cherry picked from commit da62235)

Co-authored-by: ShourieG <[email protected]>
ShourieG added a commit that referenced this pull request Jan 27, 2023
@ShourieG
Revert "fixed log naming syntax to not clash with ecs field names (#3…
a69cbd6 
…4403) (#34404)"

This reverts commit 73396eb.
ShourieG added a commit that referenced this pull request Jan 27, 2023
@ShourieG
Revert "[8.6](backport #34403) fixed log naming syntax to not clash w…
f4cb1a7 
…ith ecs field names" (#34405)

* Revert "fixed log naming syntax to not clash with ecs field names (#34403) (#34404)"

This reverts commit 73396eb.

* Update x-pack/filebeat/input/azureblobstorage/input.go
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@ShourieG @chrisberkhout
fixed log naming syntax to not clash with ecs field names (#34403)
f6fc904 
* fixed log naming syntax to not clash with ecs field names

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr was automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@ShourieG ShourieG

Labels
backport-v8.6.0 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShourieG @elasticmachine @P1llus