-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filebeat][threatintel] Ignore bad indicator IPs for MISP fileset #34195
[filebeat][threatintel] Ignore bad indicator IPs for MISP fileset #34195
Conversation
Closes #29949. MISP may send an Event.Attribute.value IP as a CIDR such as 146.88.240.0/24, which is not a valid IP per the Elasticsearch IP data type.
💚 CLA has been signed |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to add a test case for this?
I am not, due to lack of experience developing against filebeat, but you can use this MISP record as a test input: {
"Event": {
"Attribute": {
"Galaxy": [],
"ShadowAttribute": [],
"category": "Network activity",
"comment": "",
"deleted": false,
"disable_correlation": false,
"distribution": "5",
"event_id": "1528",
"first_seen": null,
"id": "4081012",
"last_seen": null,
"object_id": "0",
"object_relation": null,
"sharing_group_id": "0",
"timestamp": "1670293864",
"to_ids": true,
"type": "ip-dst",
"uuid": "4fa3610f-5412-41dd-9034-c8294fc3c7c2",
"value": "146.88.240.0/24"
},
"CryptographicKey": [],
"EventReport": [],
"Galaxy": [],
"Object": [],
"Org": {
"id": "1",
"local": true,
"name": "ORGNAME",
"uuid": "121f5d02-2e2e-4180-9166-fcad7e01a20d"
},
"Orgc": {
"id": "1",
"local": true,
"name": "ORGNAME",
"uuid": "121f5d02-2e2e-4180-9166-fcad7e01a20d"
},
"RelatedEvent": [
{
"Event": {
"Org": {
"id": "1",
"name": "ORGNAME",
"uuid": "121f5d02-2e2e-4180-9166-fcad7e01a20d"
},
"Orgc": {
"id": "3",
"name": "CIRCL",
"uuid": "55f6ea5e-2c60-40e5-964f-47a8950d210f"
},
"analysis": "2",
"date": "2018-03-26",
"distribution": "3",
"id": "896",
"info": "OSINT - Forgot About Default Accounts? No Worries, GoScanSSH Didn’t",
"org_id": "1",
"orgc_id": "3",
"published": true,
"threat_level_id": "3",
"timestamp": "1523865236",
"uuid": "5acdb4d0-b534-4713-9612-4a1d950d210f"
}
}
],
"ShadowAttribute": [],
"Tag": [
{
"colour": "#004577",
"exportable": true,
"hide_tag": false,
"id": "1",
"is_custom_galaxy": false,
"is_galaxy": false,
"local": 0,
"local_only": false,
"name": "osint:source-type=\"block-or-filter-list\"",
"numerical_value": null,
"user_id": "0"
}
],
"analysis": "2",
"attribute_count": "2053",
"date": "2022-07-26",
"disable_correlation": false,
"distribution": "0",
"event_creator_email": "[email protected]",
"extends_uuid": "",
"id": "1528",
"info": "firehol_level1 feed",
"locked": false,
"org_id": "1",
"orgc_id": "1",
"proposal_email_lock": false,
"protected": null,
"publish_timestamp": "0",
"published": false,
"sharing_group_id": "0",
"threat_level_id": "4",
"timestamp": "1672885819",
"uuid": "2ed041a1-33ea-4e54-bf26-bf1c7ce191b3"
}
} |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
…4195) MISP may send an Event.Attribute.value IP as a CIDR such as 146.88.240.0/24, which is not a valid IP per the Elasticsearch IP data type. Co-authored-by: Dan Kortschak <[email protected]>
Type of change:
What does this PR do?
Sets
ignore_failure
when attempting to process the MISPthreat.indicator.ip
usinggrok
.Why is it important?
MISP may send an Event.Attribute.value IP as a CIDR such as 146.88.240.0/24, which is not a valid IP per the Elasticsearch IP data type.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues