x-pack/filebeat/input/{cel,httpjson}: make transport keep-alives configurable #34014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
Filebeat
botelastic
bot
added
needs_team
efd6
force-pushed
the
33951-keepalive
branch
from
576de55 to
6e9ccc8
Compare
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
This comment was marked as outdated.
This comment was marked as outdated.
efd6
force-pushed
the
33951-keepalive
branch
from
6e9ccc8 to
04b3556
Compare
This comment was marked as outdated.
This comment was marked as outdated.
…igurable The behaviour defaults to the old behaviour, but exposes the full set of httpcommon.WithKeepaliveSettings configuration options.
efd6
force-pushed
the
33951-keepalive
branch
from
04b3556 to
ab2a2c0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@elasticmachine, run elasticsearch-ci/docs |
kcreddy
approved these changes
Dec 16, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
efd6
added
backport-v8.6.0
mergify bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
…igurable (#34014) The behaviour defaults to the old behaviour, but exposes the full set of httpcommon.WithKeepaliveSettings configuration options. (cherry picked from commit 3cd8d81) # Conflicts: # x-pack/filebeat/input/cel/input.go # x-pack/filebeat/input/httpjson/input.go # x-pack/filebeat/input/httpjson/request_chain_helper.go
efd6
added a commit
that referenced
this pull request
Jan 19, 2023
…nsport keep-alives configurable (#34299) * x-pack/filebeat/input/{cel,httpjson}: make transport keep-alives configurable (#34014) The behaviour defaults to the old behaviour, but exposes the full set of httpcommon.WithKeepaliveSettings configuration options. (cherry picked from commit 3cd8d81) # Conflicts: # x-pack/filebeat/input/cel/input.go # x-pack/filebeat/input/httpjson/input.go # x-pack/filebeat/input/httpjson/request_chain_helper.go * resolve conflicts Co-authored-by: Dan Kortschak <[email protected]> Co-authored-by: Dan Kortschak <[email protected]>
6 tasks
efd6
added a commit
to efd6/beats
that referenced
this pull request
Mar 6, 2023
This is a manual backport of elastic#34014 tailored to 7.17. Keep-alive options are provided for both v1 and v2 HTTPJSON, so to simplify the change the keep-alive logic is put in v2 and exported for use by v1.
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…igurable (#34014) The behaviour defaults to the old behaviour, but exposes the full set of httpcommon.WithKeepaliveSettings configuration options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes it possible for users to configure idle connection keep-alive behaviour. The behaviour defaults to the old behaviour, but exposes the full set of httpcommon.WithKeepaliveSettings configuration options.
Why is it important?
Keep-alive behaviour can have a performance and API-limit impact in some cases.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs