Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/module/cisco/asa: add handling of AAA operations and non-canonical log formats #32789

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 24, 2022

What does this PR do?

This reflects changes in the cisco_asa package added in v2.7.0 and v2.7.1.

Why is it important?

It brings funtionality in to line with the integration and fixes a user issue.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.5 candidate labels Aug 24, 2022
@efd6 efd6 self-assigned this Aug 24, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 24, 2022
@efd6 efd6 force-pushed the 32257-cisco_asa branch from a916dc7 to 9de7538 Compare August 24, 2022 02:01
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 24, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-24T22:36:14.480+0000

  • Duration: 77 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 2202
Skipped 166
Total 2368

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review August 24, 2022 05:15
@efd6 efd6 requested a review from a team as a code owner August 24, 2022 05:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 32257-cisco_asa upstream/32257-cisco_asa
git merge upstream/main
git push upstream 32257-cisco_asa

…non-canonical log formats

This reflects changes in the cisco_asa package added in v2.7.0 and v2.7.1.
@efd6 efd6 force-pushed the 32257-cisco_asa branch from 9de7538 to cfa9b27 Compare August 24, 2022 22:35
@efd6 efd6 merged commit c81abb5 into elastic:main Aug 25, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
…non-canonical log formats (#32789)

This reflects changes in the cisco_asa package added in v2.7.0 and v2.7.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.5 candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat Cisco ASA module - add ECS authentication fields for SIEM
3 participants