tests: fix test failures with node v19 change to default http clients to use keep-alive #2803
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of nodejs/node#37184 node v19 and later
defaults the http,https.globalAgent to use keep-alive:
This change in default broke a couple tests. The agent itself is
unaffected because our http client already uses a custom http agent
using keep-alive.
This should fix recent Jenkins CI failures in the "Nightly Test" stage.
E.g. https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/main/267/pipeline/7010
This started failing with the
v19.0.0-nightly20220630350a6a8d59
nightly node build which included these node commits:It is commit
4267b92604 - http: use Keep-Alive by default in global agents
that was impacted our tests.