Need to fix compilation flag lost in CMake refactor #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like we lost the O3 flag always being on. This was good for some fun trying to figure out why performance had dropped off so dramatically - turned out it was simply because prior builds had NEVER been without O3, so all builds - Debug or Release - were optimized. On the other hand, there are arguments for and against O3 with debug builds. The optimizations complicate/obscure debugging, but it's also an order of magnitude slower running. Rather than be completely either or, this PR defines a MANIFOLD_OPTIMIZED variable that a user can specify to ON explicitly. Build types Release and RelWithDebInfo will always have O3, and for other cases it'll be up to whether the user has explicitly requested optimized building with MANIFOLD_OPTIMIZED.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 91.84% 85.86% -5.99%
==========================================
Files 37 62 +25
Lines 4976 9604 +4628
Branches 0 1046 +1046
==========================================
+ Hits 4570 8246 +3676
- Misses 406 1358 +952 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we lost the O3 flag always being on. This was good for some fun trying to figure out why performance had dropped off so dramatically - turned out it was simply because prior builds had NEVER been without O3, so all builds - Debug or Release - were optimized.
On the other hand, there are arguments for and against O3 with debug builds. The optimizations complicate/obscure debugging, but it's also an order of magnitude slower running. Rather than be completely either or, this PR defines a MANIFOLD_OPTIMIZED variable that a user can specify to ON explicitly. Build types Release and RelWithDebInfo will always have O3, and for other cases it'll be up to whether the user has explicitly requested optimized building with MANIFOLD_OPTIMIZED.