Modify the iptables.go to fix some bugs #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter in line 73, `if err := p.configIPTables(false); err != nil {` should be `if err := p.configIPTables(true); err != nil {`
|
LGTM But use qdisc to solve the Haproxy reload problem could be better ref: https://engineeringblog.yelp.com/2015/04/true-zero-downtime-haproxy-reloads.html |
ehazlett
pushed a commit
that referenced
this pull request
Aug 16, 2019
nginx: Add test for canary deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter in line 73,
if err := p.configIPTables(false); err != nil {should beif err := p.configIPTables(true); err != nil {