Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interlock fails to start in polling mode if time unit not specified #184

Open
demaniak opened this issue Jul 6, 2016 · 2 comments
Open
Labels
Milestone

Comments

@demaniak
Copy link

demaniak commented Jul 6, 2016

Setting PollInterval = "5" results in interlock failing to startup.
Log output:

FATA[0000] time: missing unit in duration 5

Setting PollInterval = "5s" lets interlock start up, but I have no idea if this is a correct time unit.

Suggest documentation be updated/expanded to mention the required time unit (and available viable options)?

Also, if possible perhaps default to seconds if no time unit specified?

Currently running interlock:test.

@krishamoud
Copy link
Contributor

IMO the default time should be in milliseconds because the default polling interval is set in ms:

defaultPollInterval = time.Millisecond * 2000

@ehazlett
Copy link
Owner

ehazlett commented Jul 8, 2016

I actually think we should change the default poll as too quick could cause issues. We should default it to seconds (2s). We could then add it if missing.

@ehazlett ehazlett added this to the 1.3 milestone Jul 8, 2016
@ehazlett ehazlett modified the milestones: 1.3, 1.4 Nov 10, 2016
@ehazlett ehazlett modified the milestones: 1.3.1, 1.4 Apr 29, 2017
ehazlett added a commit that referenced this issue Aug 16, 2019
Refactor duplicated setup and verification code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants