Modifications to make work with gossamer node #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwu20
reviewed
Feb 23, 2023
timwu20
reviewed
Feb 23, 2023
Comment on lines
+256
to
+257
|
|
||
| // args.push("--no-mdns"); |
Comment on lines
-263
to
-265
| if (prometheus && !args.includes("--prometheus-external")) | ||
| args.push("--prometheus-external"); | ||
|
|
There was a problem hiding this comment.
is this because gossamer doesn't support this?
| ]; | ||
| let portFlags | ||
| let finalArgs: string[] | ||
| if (command.includes("gossamer")) { |
There was a problem hiding this comment.
I feel like this is all unnecessary if we just support the substrate flags. The command can be modified to run our binary easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains changes that enable zombienet to work with gossamer nodes, note these changes break zombienet so that it will not work with polkadot nodes.
Zombienet uses CLI flags to start the target node, since gossamer has different CLI arguments that polkadot, it is necessary to change these to make it work with gossamer. (Note, this is just for research, there are many different ways that we can make these work together, this is done to determine what the differences are.)
cmdGenerater.tsare where the zombienet code has been changed to work with gossamer nodes.chainfolder was added for testing, this contains chain spec files for testing with gossamer.examples/0001-westend-local-network.tomlto spawn a local network using the westend chain spec.default_commandparameter points to a local instance of gossamer, this would normally be justgossamerassuminggossameris in your path, but I've pointed to my development path for gossamer since I've been updating gossamer as I've been testing.--configflag in args attribute should not be necessary since zombienet normally starts nodes using CLI arguments and not a config file, but there seems to be a bug in gossamer where some config attributes from config file are necessary to start a node in role 4 (grandpa authority).--node-keyto define the libp2p key used to setup networking, the current gossamer node does not have this flag, using gossamer node from branched/sombienet_testinghas this CLI argument. https://github.com/ChainSafe/gossamer/tree/ed/zombienet_testingYou can start the westend local test network with 3 nodes using the following command:
node javascript/packages/cli/dist/cli.js spawn --provider native examples/0001-westend-local-network.tomlTo start with debugging logs use:
DEBUG=zombie* node javascript/packages/cli/dist/cli.js spawn --provider native examples/0001-westend-local-network.tomlTo start testing nodes using test file
example/0001-westend-local-network.zndsl(Note most if these tests fail, but the testing framework is working),DEBUG=zombie* node javascript/packages/cli/dist/cli.js test --provider native examples/0001-westend-local-network.zndsl