Skip to content

Commit

Permalink
Die rather than warn if a Docker image is missing
Browse files Browse the repository at this point in the history
The warning was done to handle older Nix releases that didn't have
Docker images (091f232), but this was
a bad idea because it causes us to silently skip uploading Docker
images if e.g. Hydra hasn't finished building them yet.

Issue NixOS#10648.
  • Loading branch information
edolstra committed May 10, 2024
1 parent de8c3c0 commit 6df07f3
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions maintainers/upload-release.pl
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,7 @@ sub downloadFile {
eval {
downloadFile("dockerImage.$system", "1", $fn);
};
if ($@) {
warn "$@" if $@;
next;
}
die "$@" if $@;
$haveDocker = 1;

print STDERR "loading docker image for $dockerPlatform...\n";
Expand Down

0 comments on commit 6df07f3

Please sign in to comment.