-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow upgrades on azure without Terraform changes on LBs created from within Kubernetes #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3u13r
force-pushed
the
fix/azure/upgrade-lb-terraform-issue
branch
4 times, most recently
from
July 21, 2024 21:11
4d13479
to
6ed8523
Compare
3u13r
changed the title
k8s: use separate lb for K8s services on azure
Allow upgrades on azure without Terraform changes on LBs created from within Kubernetes
Jul 21, 2024
3u13r
force-pushed
the
fix/azure/upgrade-lb-terraform-issue
branch
6 times, most recently
from
July 22, 2024 01:41
12c040e
to
5b950e5
Compare
3u13r
requested review from
burgerdev,
msanft and
daniel-weisse
and removed request for
derpsteb
July 22, 2024 01:53
burgerdev
reviewed
Jul 22, 2024
3 tasks
3u13r
force-pushed
the
fix/azure/upgrade-lb-terraform-issue
branch
4 times, most recently
from
October 7, 2024 15:44
7d586f1
to
69d6383
Compare
3u13r
force-pushed
the
fix/azure/upgrade-lb-terraform-issue
branch
2 times, most recently
from
October 7, 2024 16:38
e18819c
to
e804d9a
Compare
3u13r
force-pushed
the
fix/azure/upgrade-lb-terraform-issue
branch
from
October 7, 2024 21:13
e804d9a
to
abd03b2
Compare
burgerdev
approved these changes
Oct 8, 2024
daniel-weisse
approved these changes
Oct 8, 2024
thomasten
reviewed
Oct 8, 2024
Coverage report
|
thomasten
approved these changes
Oct 9, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Proposed change(s)
Azure, snp, 1:2, lb: https://github.com/edgelesssys/constellation/actions/runs/11220341955
Azure, snp, 1:2, upgrade: https://github.com/edgelesssys/constellation/actions/runs/11220359763
Checklist