A bunch of tests that were mismatched between sycn/async. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyncQueryTestCase base type was accidentally used with async test methods. Now they are all sync. A bug got fixed in an upcoming 6.0 version, so the test_async_query_sql_01 is no longer an expectedFailure for newer server, but will fail on older build. Skip for older builds.
msullivan
approved these changes
Dec 13, 2024
Comment on lines
+1156
to
+1159
| if await self.client.query_required_single(''' | ||
| select sys::get_version().major < 6 | ||
| '''): | ||
| self.skipTest("Buggy in versions earlier than 6.0") |
There was a problem hiding this comment.
What happens? Probably we want some useful error mode there.
There was a problem hiding this comment.
Like, edgedb-python should refuse to do query_sql if it isn't on proto v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyncQueryTestCase base type was accidentally used with async test methods. Now thye are all sync.