Implement gel.Record type #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's returned from `client.query_sql()` and represents SQL rows. Currently it supports: * integer indexing - fetch columns by position * string indexing - fetch columns by name * as_dict() method - render record as a dict ToDo: * add __iter__
msullivan
reviewed
Dec 12, 2024
gel/datatypes/object.c
Outdated
| @@ -284,7 +265,7 @@ object_repr(EdgeObject *o) | |||
|
|
|||
| if (_EdgeGeneric_RenderItems(&writer, | |||
| (PyObject *)o, o->desc, | |||
| o->ob_item, Py_SIZE(o), 1, 0) < 0) | |||
| o->ob_item, Py_SIZE(o), 1, 1, 0) < 0) | |||
There was a problem hiding this comment.
You don't really need to fix this now, but this sort of list of boolean arguments ought to either have comments saying what each of the argument names are or should use #defines/enums or flag bits or something. 1, 1, 0 is inscrutable.
This is an existing problem, though, so it's fine to skip fixing it now.
There was a problem hiding this comment.
Fixed in Apply better style for passing flags
msullivan
approved these changes
Dec 12, 2024
What's duplicated? Besides the Record codec looking like a stripped down Object codec? Edit: here's the previous attempt 00650b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's returned from
client.query_sql()and represents SQL rows.Currently it supports:
ToDo: