Fix inference when action names are not alphabetic #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix that should enable onnx inference to work for environments where the actions are not defined in an alphabetical order by name.
Only briefly tested, I have tried to quickly start training using
gdrl
andplay
in Editor.To do:
For an example action space that is not sorted:
With the applied fix, the action space as Printed from Python was:
(same as the order written in AIController in gdscript)
Without the fix, the order of actions is changed before it reaches Python:
More info on the issue itself is described in the linked issue.