Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify iterations for sb3 #48

Closed
wants to merge 1 commit into from

Conversation

ryash072007
Copy link
Collaborator

@edbeeching I think this would be useful when using sb3, instead of manually having to change the iteration value, it can be a command line argument which would make it easier to change it.

@edbeeching
Copy link
Owner

Thanks, I have been thinking more about how best to structure the library, would it be better to have one file per backend, so we can specify backend specific args more easily? What do you think?

@ryash072007
Copy link
Collaborator Author

Thanks, I have been thinking more about how best to structure the library, would it be better to have one file per backend, so we can specify backend specific args more easily? What do you think?

I was thinking about the same for sb3. It would make it easier in my opinion. I definitely support this method more then the current.

@edbeeching
Copy link
Owner

@ryash072007 this is superceded by #135, I will close. Feel free to test out #135 to be sure it has all the features you would like.

@edbeeching edbeeching closed this Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants