-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ADV_STABLE_BASELINES_3.md #136
Conversation
Updated the docs for the sb3 example. Removed the code snippet since the example file is already linked, it may be easier than keeping the code snippet updated with each change to the example.
docs/ADV_STABLE_BASELINES_3.md
Outdated
) | ||
### Train an exported environment using 8 times speedup: | ||
```bash | ||
python .\stable_baselines3_example.py --env_path=path_to_executable --speedup=8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to include the .\
in front of every command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart for the .\
, is this a windows thing?
I'll check if it works without it, it might be needed in Windows Powershell (used with Anaconda) as it autocompletes for me that way (typing python then pressing tab). If it's not needed, I'll remove it, but if it is needed I'll have to think about a solution to address both cases. Does it work that way in Linux? Edit: It seems to work fine without the addition, I'll remove it from the docs. |
Ye in linux it would just be: python stable_baselines3_example.py --env_path=path_to_executable --speedup=8 |
Thanks for noticing this, I made a quick check and it seems to be Windows Powershell specific, so it wouldn't work for other OS. However, it works without the extra |
small correction
Updated the docs for the sb3 example. Removed the code snippet since the example file is already linked, it may be easier than keeping the code snippet updated with each change to the example.