Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADV_STABLE_BASELINES_3.md #136

Merged
merged 3 commits into from
Jul 23, 2023
Merged

Update ADV_STABLE_BASELINES_3.md #136

merged 3 commits into from
Jul 23, 2023

Conversation

Ivan-267
Copy link
Collaborator

Updated the docs for the sb3 example. Removed the code snippet since the example file is already linked, it may be easier than keeping the code snippet updated with each change to the example.

Updated the docs for the sb3 example. Removed the code snippet since the example file is already linked, it may be easier than keeping the code snippet updated with each change to the example.
)
### Train an exported environment using 8 times speedup:
```bash
python .\stable_baselines3_example.py --env_path=path_to_executable --speedup=8
Copy link
Owner

@edbeeching edbeeching Jul 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to include the .\ in front of every command?

Copy link
Owner

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart for the .\ , is this a windows thing?

@Ivan-267
Copy link
Collaborator Author

Ivan-267 commented Jul 23, 2023

LGTM apart for the .\ , is this a windows thing?

I'll check if it works without it, it might be needed in Windows Powershell (used with Anaconda) as it autocompletes for me that way (typing python then pressing tab). If it's not needed, I'll remove it, but if it is needed I'll have to think about a solution to address both cases. Does it work that way in Linux?

Edit: It seems to work fine without the addition, I'll remove it from the docs.

@edbeeching
Copy link
Owner

Ye in linux it would just be:

python stable_baselines3_example.py --env_path=path_to_executable --speedup=8

@Ivan-267
Copy link
Collaborator Author

Ye in linux it would just be:

python stable_baselines3_example.py --env_path=path_to_executable --speedup=8

Thanks for noticing this, I made a quick check and it seems to be Windows Powershell specific, so it wouldn't work for other OS. However, it works without the extra ./ in Powershell as well. I updated the docs to resolve it.

@Ivan-267 Ivan-267 merged commit 101e6f6 into main Jul 23, 2023
@Ivan-267 Ivan-267 deleted the sb3_example_docs_update branch July 23, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants