Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: experiment_dir + experiment_name #126

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Feature: experiment_dir + experiment_name #126

merged 3 commits into from
Jul 16, 2023

Conversation

visuallization
Copy link
Collaborator

@visuallization visuallization commented Jul 15, 2023 •
edited
Loading

  • Added posssibility to set experiment_dir in every rl backend + unify location name
  • Added posssibility to set experiment_name in every rl backend
  • Added monitor reward in sb3wrapper
  • Fix sample-factory version to make gdrl still work with gym and not gymnasium

@visuallization visuallization self-assigned this Jul 15, 2023
@visuallization visuallization changed the title Feature: experiment_name Feature: experiment_dir + experiment_name Jul 15, 2023
@visuallization visuallization requested a review from Ivan-267 July 15, 2023 13:16
edbeeching
edbeeching approved these changes Jul 15, 2023
View reviewed changes
Copy link
Owner

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes, have you tested them for all the different RL frameworks?

@visuallization
Copy link
Collaborator Author

@edbeeching Yes I am currently working with these changes in all different RL frameworks and it all seems to work fine, as far as I can tell.

@visuallization visuallization merged commit cfa756c into main Jul 16, 2023
@visuallization visuallization deleted the feature/experiment-name branch July 16, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbeeching edbeeching edbeeching approved these changes

@Ivan-267 Ivan-267 Awaiting requested review from Ivan-267

Assignees

@visuallization visuallization

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visuallization @edbeeching