Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Charsets like Cyrillic should break work the same as Latin #973

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: Charsets like Cyrillic should break work the same as Latin #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/graphic/helper/parseText.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,9 +591,17 @@ function pushTokens(
}


function isLatin(ch: string) {
function isAlphabeticLetter(ch: string) {
// Unicode Character Ranges
// https://jrgraphix.net/research/unicode_blocks.php
// The following ranges may not cover all letter ranges but only the more
// popular ones. Developers could make pull requests when they find those
// not covered.
let code = ch.charCodeAt(0);
return code >= 0x21 && code <= 0x17F;
return code >= 0x20 && code <= 0x24F // Latin
|| code >= 0x370 && code <= 0x10FF // Greek, Coptic, Cyrilic, and etc.
|| code >= 0x1200 && code <= 0x13FF // Ethiopic and Cherokee
|| code >= 0x1E00 && code <= 0x206F; // Latin and Greek extended
}

const breakCharMap = reduce(',&?/;] '.split(''), function (obj, ch) {
Expand All @@ -604,7 +612,7 @@ const breakCharMap = reduce(',&?/;] '.split(''), function (obj, ch) {
* If break by word. For latin languages.
*/
function isWordBreakChar(ch: string) {
if (isLatin(ch)) {
if (isAlphabeticLetter(ch)) {
if (breakCharMap[ch]) {
return true;
}
Expand Down