-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SSE data reporting #1298
fix: SSE data reporting #1298
Conversation
Some comments:
Given that 1 is always the case for sse and we can understand that from subprotocol, it is fine to put json in the form content type. |
This is something that (I think) goes beyond this PR. I suggest to open another issue/PR for that. @egekorkan w.r.t. the other comments I am not sure whether they affect "this" PR. There is a test added that checks the consistency of the change. Do you want me to change the PR further? |
I think I got confused after some discussions with @relu91 and commented here. My comments do not affect this PR. |
works |
fixes #1294