Feature Proposal: Rasterization of SVGs at Runtime for Eclipse Icons #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
org.eclipse.search org.eclipse.ui org.eclipse.ui.ide org.eclipse.ui.ide.application org.eclipse.ui.editors org.eclipse.ui.navigator
|
I just pushed the changes I made for/in our yesterdays 1:1 meeting, mainly adapt to the change that |
HannesWell
reviewed
Dec 17, 2024
Comment on lines
+66
to
+67
| try (InputStream in = getStream(tempURL)) { | ||
| if (rasterizer.isSVGFile(in)) { |
There was a problem hiding this comment.
If we would just check the file-extension here we would save creating an InputStream for each image to render. The latter is probably a significant performance overhead.
Furthermore it would save us from making SVGRasterizerRegistry and SVGRasterizer public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the following PR in Eclipse SWT for a detailed description of the changes.
Fixes eclipse-platform/eclipse.platform.swt#1438.