Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Add Consent Management to the Appstore #113

Closed
bs-jokri opened this issue Sep 19, 2019 · 6 comments
Closed

Add Consent Management to the Appstore #113

bs-jokri opened this issue Sep 19, 2019 · 6 comments
Labels
app store all issues related to the app store enhancement New feature or request

Comments

@bs-jokri
Copy link
Contributor

As of now the Appstore does not ask the user to give consent to the data that is accessed from a App to be installed. It should be that the appstore request the user to give consent prior installing an app.

Possible approach:

  1. A text file with data or functionality of the car used by the app is stored in the app image
  2. The text file is evaluated by the app publisher and written into the description field of an artifact in hawkbit
  3. The appstore evaluates this description and shows it to the user prior installing an app.
@bs-jokri bs-jokri added enhancement New feature or request app store all issues related to the app store labels Sep 19, 2019
@trademkose
Copy link
Contributor

trademkose commented Oct 23, 2019

@bs-jokri Hi,
This development has been done. I added an example PERMISSIONFILE.JSON at resourse folder to specify permissions that the car will use. The permisson file's name should be like PERMISSONFILE.JSON and I decided a json format for permission object like this;

{
"name": "CAMERA",
"type": "CRITICAL",
"displayName": "Camere permission",
"description" : "Camere permission description"
}

We need to upload this file to every single app image. Appstore will read this file before app installation and AppStore will ask this permission to confirm.

resim

@bs-jokri
Copy link
Contributor Author

@trademkose this looks fantastic! Thank you for your efforts. For me this looks like what we need as a first step for the consent management and to demonstrate the overall approach. One question: What happens if an app does not have a PERMISSIONFILE.JSON?

@eriksven @phil-hei @rai20 what do you think?

@trademkose
Copy link
Contributor

If an app doesn't have a PERMISSIONFILE.JSON, Appstore shows an error message like this, "PERMISSIONFILE.JSON not found or empty." and than you can install the application even if you see this error.

eriksven pushed a commit that referenced this issue Nov 6, 2019
* Bug Fixed in Appservice. Added null check.

Signed-off-by: Adem KOSE <[email protected]>

* Add Consent Management to the Appstore #113

Signed-off-by: Adem KOSE <[email protected]>

* Changed convertPermissionArtifactFileToStringList name of method to permissionArtifactStringToList in Utils class.

Signed-off-by: Adem KOSE <[email protected]>

* Changed file name to PERMISSION.JSON
Signed-off-by: Adem KOSE <[email protected]>
@phil-hei
Copy link
Contributor

Looks good and works for me. Thanks! We'll probbaly integrate that in the IDE by generating an according json out of the user inputs regarding consent infos and upload it to hawkbit

@bs-jokri
Copy link
Contributor Author

bs-jokri commented Dec 5, 2019

@trademkose @phil-hei seems this issue is resolved. Can we close?

@trademkose
Copy link
Contributor

@bs-jokri I think. We can close.

@rohoet rohoet closed this as completed Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app store all issues related to the app store enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants