Do not count iterations aborted during shutdown #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this the displayed number of published updates did not match the number of received updates when aborting a run.
Wrapping the shutdown handler in an Arc<RwLock> is unnecessary as it can be cloned freely.
argerus
force-pushed
the
feature/fix_recording_during_shutdown
branch
from
3addb4a to
8749403
Compare
|
If this is merged we do not need #8 right? Looks good to me. Downloaded it and started it and used ctrl-c, seems ok If you like you could increase version in Cargo.toml to 0.3.2 and update lock so we can trigger a new release as stated in https://github.com/eclipse-kuksa/kuksa-perf/wiki/Release-Process |
No, exactly. |
erikbosch
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this the displayed number of published updates will not match the number of received updates when aborting a run.
Also remove a superfluous
Arc<RwLock>