[master] OXM Tests move from MOXy to Core module #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stence.core.test module Signed-off-by: Radek Felcman <[email protected]>
Signed-off-by: Radek Felcman <[email protected]>
|
OXM tests do have no dependency on the test framework, why can't they be moved to the |
Signed-off-by: Radek Felcman <[email protected]>
rfelcman
changed the title
OK OXM tests are now in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main reason for this change is, that OXM tests are focused on Core module functionality not MOXy JAXB implementation.
Due this change there are some code changes in the following tests/test suites:
org.eclipse.persistence.testing.oxm/jaxb.converter.ConverterTestSuiteThere is split of test cases:
ObjectTypeConverterTestCasesis moved to the OXM/CoreTypeSafeEnumConverterTestCases,JAXBEnumTypeConverterTestCasesand related classes remains in MOXy as these test cases testing JAXB/MOXy functionalityorg.eclipse.persistence.jaxb.JAXBTypesafeEnumConverterNew
org.eclipse.persistence.testing.oxm.OXMXMLComparerin Core.test and currentorg.eclipse.persistence.testing.jaxb.JAXBXMLComparerin MOXy inherits functionality.In
moxy/org.eclipse.persistence.moxy/src/test/java/org/eclipse/persistence/testing/jaxb/xmlmarshallerresource path changes to reflect new resource files locationorg/eclipse/persistence/testing/oxm/jaxb/->org/eclipse/persistence/testing/jaxb/xmlmarshaller/.../src/test/resources/sessions.xmlsplit: as some sessions specified there are related with OXM and some with MOXy testsGenerateSchemaTestCases: comparer change fromorg.eclipse.persistence.testing.jaxb.JAXBXMLComparertoorg.eclipse.persistence.testing.oxm.OXMXMLCompareras tests were moved into OXM/Core.test scopeThere is some change in
bundles/nightly/pom.xmlas OXM html report published at the Nightly builds page now is produced by Core.test module instead of MOXy module.I tried to move all unit tests
src/testfromorg.eclipse.persistence.core.testtoorg.eclipse.persistence.coremodule to simplify project structure but there are some blockers due dependency toorg.eclipse.persistence.core.test.frameworkmodule. It's not related with moved OXM tests, but with current tests in Core.test module.Signed-off-by: Radek Felcman [email protected]