Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

few errors/warnings from static analysis #1305

Merged
merged 1 commit into from
Sep 17, 2021
Merged

few errors/warnings from static analysis #1305

merged 1 commit into from
Sep 17, 2021

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Sep 17, 2021

Signed-off-by: Lukas Jungmann [email protected]

@lukasj lukasj requested a review from rfelcman September 17, 2021 06:43
rfelcman
rfelcman approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request fixes 46 alerts when merging 54abb16 into 51a8600 - view on LGTM.com

fixed alerts:

  • 15 for Misleading indentation
  • 10 for Spurious Javadoc @param tags
  • 6 for Contradictory type checks
  • 5 for Cast from abstract to concrete collection
  • 3 for Container contents are never accessed
  • 3 for Missing space in string literal
  • 1 for Useless comparison test
  • 1 for Container size compared to zero
  • 1 for Dereferenced variable is always null
  • 1 for Boxed variable is never null

@lukasj lukasj merged commit 335f958 into eclipse-ee4j:master Sep 17, 2021
@lukasj lukasj deleted the bg branch September 17, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfelcman rfelcman rfelcman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasj @rfelcman