Fix the ENV about configuration folder to set when using docker image #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the launcher Change-Id: Ic88018709671e36e23fbceeb9e5cee5dd5ee0129 Signed-off-by: Florent BENOIT <[email protected]>
|
+1 - ok to merge. |
benoitf
added
kind/enhancement
|
Build # 1267 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1267/ to view the results. |
TylerJewell
removed
the
status/code-review
ShimonBenYair
pushed a commit
to ShimonBenYair/che
that referenced
this pull request
Aug 4, 2016
… in the launcher (eclipse-che#1896) Change-Id: Ic88018709671e36e23fbceeb9e5cee5dd5ee0129 Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the environment variable setup on configuration folder
What issues does this PR fix or reference?
Previous Behavior
Previously, when using the CHE_CONF_FOLDER to the launcher, there was an invalid argument given to the docker container with quotes
New Behavior
Variable is given as expected
Tests written?
No