Add docker image to grab the ip used by docker #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id781e34c99f14c87909197b99969d645268e62d3 Signed-off-by: Florent BENOIT <[email protected]>
|
lgtm |
20 tasks
benoitf
added
kind/enhancement
ShimonBenYair
pushed a commit
to ShimonBenYair/che
that referenced
this pull request
Aug 4, 2016
Change-Id: Id781e34c99f14c87909197b99969d645268e62d3 Signed-off-by: Florent BENOIT <[email protected]>
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduce docker image to get ip used by docker
What issues does this PR fix or reference?
Previous Behavior
hardcoded in the launcher script but it could be done within a docker image as well to share it with other docker images
New Behavior
New 'codenvy/che-ip' docker image
Tests written?
No
Change-Id: Id781e34c99f14c87909197b99969d645268e62d3
Signed-off-by: Florent BENOIT [email protected]