Downgrade docker installed in Che image #1833
Conversation
|
Can one of the admins verify this patch? |
|
Lgtm |
|
@l0rd wouldn't it be possible then that client IP version is lower than the one a user might have locally? |
|
@eivantsov yes that's the goal: docker client version inside the container is lower than docker daemon version on the host. The client does not complain speaking with a daemon that uses a more recent API. And the docker commands we use in the shell scripts works fine. That's the same solution used by Rancher agent: https://github.com/rancher/rancher/blob/master/agent/Dockerfile#L24. They have the same need that we do (a client inside a container that need to speak to daemons of any version) and they solved it using a Docker client version 1.6. |
| apk add --update docker openjdk8 sudo bash && \ | ||
| apk add --update ca-certificates curl openssl openjdk8 sudo bash && \ | ||
| curl -sL "https://${DOCKER_BUCKET}/builds/Linux/x86_64/docker-$DOCKER_VERSION" \ | ||
| > /usr/bin/docker; chmod +x /usr/bin/docker && \ |
There was a problem hiding this comment.
I think that > /usr/bin/docker is an ending of previous command should not be moved to a new line.
Also ; chmod +x /usr/bin/docker means skip error of previous step. It is better to use && instead
l0rd
force-pushed
the
downgrade-docker-version
branch
from
1d4924d to
0fb6ebe
Compare
|
@garagatyi I've updated / splitted the curl command |
|
lgtm +1 |
|
LGTM |
|
We should merge this after #1683 |
Signed-off-by: Mario Loriedo <[email protected]>
l0rd
force-pushed
the
downgrade-docker-version
branch
from
0fb6ebe to
480fb6d
Compare
|
Thanks, @l0rd for the fix. |
TylerJewell
added
the
kind/bug
What does this PR do?
Use Docker version 1.6 in Che image
What issues does this PR fix or reference?
On a machine with Docker 1.10 or lower Che failed to start in a container.
Previous Behavior
New Behavior
Tests written?
No
Docs requirements?
No
Signed-off-by: Mario Loriedo [email protected]