CODENVY-651 Save machine config with 'dev' instead of 'isDev' field #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
ok. @evoevodin ? |
|
ok, don't forget to fix this |
|
Build # 1162 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1162/ to view the results. |
|
ok. do not merge until 4.6 |
|
agree with @skabashnyuk, do not merge this please to until we release 4.5. And do not forget prepare issue with migration script. |
skabashnyuk
added
kind/enhancement
mkuznyetsov
force-pushed
the
CODENVY-651
branch
2 times, most recently
from
b110569 to
79a3f8c
Compare
|
After checking all tests we do not have any regressions as compared with nightly4 server. |
|
Build # 1286 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1286/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change MachineConfigImpl field 'isDev' to 'dev', as it is done in MachineConfigDto.
It should fix consitensy problems.
Also it needs to make migrations of existing workspaces.