Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop of Che container in new Che launcher is broken #1949

Closed
garagatyi opened this issue Jul 26, 2016 · 3 comments · Fixed by #1956
Closed

Stop of Che container in new Che launcher is broken #1949

garagatyi opened this issue Jul 26, 2016 · 3 comments · Fixed by #1956
Assignees
@TylerJewell
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Milestone
4.6.0

Comments

@garagatyi
Copy link

New Che launcher stop Che and suppresses error output. Then container is removed with docker rm -f.
Because of that Che doesn't store created workspaces and other information into data storage folder.

Reproduction Steps:

  1. Start Che in a container
  2. Create workspace
  3. Stop Che with Che launcher
  4. Restart Che

Expected behavior:

Created workspace exists

Observed behavior:

There is no workspaces in Che

Che version: 4.6.0-Snapshot
OS and version: Ubuntu 14.04
Docker version: 1.11.2
Che install: Docker container

Additional information:

  • Problem started happening recently, didn't happen in an older version of Che: [Yes]
  • Problem can be reliably reproduced, doesn't happen randomly: [Yes]
@garagatyi garagatyi added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 26, 2016
@riuvshin riuvshin added the severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. label Jul 26, 2016
@riuvshin riuvshin added this to the 4.6.0 milestone Jul 26, 2016
@TylerJewell TylerJewell mentioned this issue Jul 26, 2016
Closed
@jcpowermac
Copy link

@TylerJewell this is exactly the problem I experienced. Once there is a PR I will be willing to test it out.

@TylerJewell
Copy link

@jcpowermac - in diagnostics, it seems to be error in the way that che-launcher executes a stop. I experienced it yesterday on MacOS.

@bmicklea
Copy link

For @l0rd to fix.

l0rd added a commit to l0rd/che that referenced this issue Jul 26, 2016
@l0rd
Launcher: stop che-server cleanly (fix eclipse-che#1949)
b15be7e 
Signed-off-by: Mario Loriedo <[email protected]>
@l0rd l0rd mentioned this issue Jul 26, 2016
Merged
TylerJewell pushed a commit that referenced this issue Jul 26, 2016
@l0rd
Launcher: stop che-server cleanly (fix #1949) (#1956)
a8984da 
Signed-off-by: Mario Loriedo <[email protected]>
@bmicklea bmicklea mentioned this issue Jul 26, 2016
Closed
64 tasks
tolusha pushed a commit that referenced this issue Aug 1, 2016
@l0rd
Launcher: stop che-server cleanly (fix #1949) (#1956)
32f2be9 
Signed-off-by: Mario Loriedo <[email protected]>
ShimonBenYair pushed a commit to ShimonBenYair/che that referenced this issue Aug 4, 2016
@l0rd @ShimonBenYair
Launcher: stop che-server cleanly (fix eclipse-che#1949) (eclipse-che…
a84f71f 
…#1956)

Signed-off-by: Mario Loriedo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerJewell TylerJewell

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

Launcher: stop che-server cleanly (fix #1949) l0rd/che
5 participants
@TylerJewell @riuvshin @garagatyi @jcpowermac @bmicklea